* [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL
@ 2022-08-11 7:07 kavya
2022-08-11 8:56 ` Guo, Gua
2022-08-12 23:03 ` [edk2-devel] " Guo Dong
0 siblings, 2 replies; 3+ messages in thread
From: kavya @ 2022-08-11 7:07 UTC (permalink / raw)
To: devel; +Cc: Kavya, Guo Dong, Ray Ni, Sean Rhodes, Gua Guo
Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration
to FALSE when root bridge count is zero.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: Kavya <k.kavyax.sravanthi@intel.com>
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
index e1faa24ae7..fb76853072 100644
--- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
+++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
@@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob (
}
if (PciRootBridgeInfo->Count == 0) {
+ PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
return NULL;
}
@@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob (
if (PciRootBridgeInfo->ResourceAssigned) {
PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE);
} else {
- DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is FALSE\n"));
+ DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is FALSE\n"));
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
- return NULL;
}
return PciRootBridges;
--
2.30.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL
2022-08-11 7:07 [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL kavya
@ 2022-08-11 8:56 ` Guo, Gua
2022-08-12 23:03 ` [edk2-devel] " Guo Dong
1 sibling, 0 replies; 3+ messages in thread
From: Guo, Gua @ 2022-08-11 8:56 UTC (permalink / raw)
To: Sravanthi, K KavyaX, devel@edk2.groups.io
Cc: Dong, Guo, Ni, Ray, Rhodes, Sean
Reviewd-by: Gua Guo <gua.guo@intel.com>
-----Original Message-----
From: Sravanthi, K KavyaX <k.kavyax.sravanthi@intel.com>
Sent: Thursday, August 11, 2022 3:08 PM
To: devel@edk2.groups.io
Cc: Sravanthi, K KavyaX <k.kavyax.sravanthi@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL
Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration to FALSE when root bridge count is zero.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: Kavya <k.kavyax.sravanthi@intel.com>
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
index e1faa24ae7..fb76853072 100644
--- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
+++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
@@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob (
}
if (PciRootBridgeInfo->Count == 0) {
+ PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
return NULL;
}
@@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob (
if (PciRootBridgeInfo->ResourceAssigned) {
PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE);
} else {
- DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is FALSE\n"));
+ DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is
+ FALSE\n"));
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
- return NULL;
}
return PciRootBridges;
--
2.30.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL
2022-08-11 7:07 [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL kavya
2022-08-11 8:56 ` Guo, Gua
@ 2022-08-12 23:03 ` Guo Dong
1 sibling, 0 replies; 3+ messages in thread
From: Guo Dong @ 2022-08-12 23:03 UTC (permalink / raw)
To: devel@edk2.groups.io, Sravanthi, K KavyaX; +Cc: Ni, Ray, Rhodes, Sean, Guo, Gua
Reviewed-by: Guo Dong <guo.dong@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of kavya
Sent: Thursday, August 11, 2022 12:08 AM
To: devel@edk2.groups.io
Cc: Sravanthi, K KavyaX <k.kavyax.sravanthi@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Guo, Gua <gua.guo@intel.com>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL
Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration to FALSE when root bridge count is zero.
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: Kavya <k.kavyax.sravanthi@intel.com>
---
UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
index e1faa24ae7..fb76853072 100644
--- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
+++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
@@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob (
}
if (PciRootBridgeInfo->Count == 0) {
+ PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
return NULL;
}
@@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob (
if (PciRootBridgeInfo->ResourceAssigned) {
PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE);
} else {
- DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is FALSE\n"));
+ DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is
+ FALSE\n"));
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
- return NULL;
}
return PciRootBridges;
--
2.30.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-12 23:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-11 7:07 [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL kavya
2022-08-11 8:56 ` Guo, Gua
2022-08-12 23:03 ` [edk2-devel] " Guo Dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox