[PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix build break when Secure Boot is enabled

[PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix build break when Secure Boot is enabled

[Sami Mujawar]

The edk2 patch at:
"6eb407947592 SecurityPkg: SecureBootVariableLib: Added
newly supported interfaces" introduced a new dependency
of PlatformPKProtectionLib to SecureBootVariableLib.

This causes the FVP model platform builds to fail when
Secure Boot is enabled (i.e. SECURE_BOOT_ENABLE = TRUE).

Therefore, add PlatformPKProtectionLib library instance
to Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc to fix
the build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Thomas Abraham <thomas.abraham@arm.com>

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index e637f8933f792753213740f838e16e7180dd9469..17e4a3fd13d7517fd5e357e2cfc8aadd96dcdeea 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -143,6 +143,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix build break when Secure Boot is enabled

[Ard Biesheuvel]

On Mon, 15 Aug 2022 at 16:10, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> The edk2 patch at:
> "6eb407947592 SecurityPkg: SecureBootVariableLib: Added
> newly supported interfaces" introduced a new dependency
> of PlatformPKProtectionLib to SecureBootVariableLib.
>
> This causes the FVP model platform builds to fail when
> Secure Boot is enabled (i.e. SECURE_BOOT_ENABLE = TRUE).
>
> Therefore, add PlatformPKProtectionLib library instance
> to Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc to fix
> the build.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>

Thanks for the fix

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as 01e3a8877180..9675047d7245

> ---
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> index e637f8933f792753213740f838e16e7180dd9469..17e4a3fd13d7517fd5e357e2cfc8aadd96dcdeea 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> @@ -143,6 +143,7 @@ [LibraryClasses.common]
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>    SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>    SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>    # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
>    PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
> 
>
>