From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Eric Dong <eric.dong@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512
Date: Mon, 15 Aug 2022 16:47:17 +0200 [thread overview]
Message-ID: <20220815144717.uxzfgghjjuvnkf64@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220810081140.158578-2-osteffen@redhat.com>
On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote:
> From: Laszlo Ersek <lersek@redhat.com>
>
> Increase the maximum line length for debug messages.
> While log messages should be short, they can still
> get quite long, for example when printing device paths
> or config strings in HII routing.
> 512 chars is an empirically good value.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
> OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> index 4e25f198aa76..640627f38b72 100644
> --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> @@ -21,7 +21,7 @@
> //
> // Define the maximum debug and assert message length that this library supports
> //
> -#define MAX_DEBUG_MESSAGE_LENGTH 0x100
> +#define MAX_DEBUG_MESSAGE_LENGTH 0x200
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2022-08-15 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 8:11 [PATCH v1 0/1] OvmfPkg: increase max debug message length to 512 Oliver Steffen
2022-08-10 8:11 ` [PATCH v1 1/1] " Oliver Steffen
2022-08-15 14:47 ` Gerd Hoffmann [this message]
2022-09-05 13:55 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815144717.uxzfgghjjuvnkf64@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox