From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.3003.1660574845981267148 for ; Mon, 15 Aug 2022 07:47:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UWqNxWJL; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660574845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyQoyBgl/8V1aCMNxMisJUMM9fxP1GVMCmDjc5182wM=; b=UWqNxWJLlu9pYQQF+6YQwb8k7ZZFyofvN7e7CZ65+IbYjYyyVYmhjXnVlqTM3HmD/yOfP0 i962Ky1iMYqD8Czof3DANid/hXxgJ7yksRduKd9Nt4cYoMCyxucMKYNVCZwi+bRevN96rK 8kWNal3frpa2RXjc+PwlUBHUaNYP5Sc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-412-Q9k56avWNZmnHtqXBvgGxg-1; Mon, 15 Aug 2022 10:47:21 -0400 X-MC-Unique: Q9k56avWNZmnHtqXBvgGxg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94C95A0CA65; Mon, 15 Aug 2022 14:47:20 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 640D7492C3B; Mon, 15 Aug 2022 14:47:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 878FE1800082; Mon, 15 Aug 2022 16:47:17 +0200 (CEST) Date: Mon, 15 Aug 2022 16:47:17 +0200 From: "Gerd Hoffmann" To: Oliver Steffen Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Eric Dong , Jiewen Yao , Jordan Justen , Rahul Kumar , Ray Ni Subject: Re: [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512 Message-ID: <20220815144717.uxzfgghjjuvnkf64@sirius.home.kraxel.org> References: <20220810081140.158578-1-osteffen@redhat.com> <20220810081140.158578-2-osteffen@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220810081140.158578-2-osteffen@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote: > From: Laszlo Ersek > > Increase the maximum line length for debug messages. > While log messages should be short, they can still > get quite long, for example when printing device paths > or config strings in HII routing. > 512 chars is an empirically good value. > > Signed-off-by: Laszlo Ersek > Signed-off-by: Oliver Steffen > --- > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > index 4e25f198aa76..640627f38b72 100644 > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > @@ -21,7 +21,7 @@ > // > // Define the maximum debug and assert message length that this library supports > // > -#define MAX_DEBUG_MESSAGE_LENGTH 0x100 > +#define MAX_DEBUG_MESSAGE_LENGTH 0x200 Acked-by: Gerd Hoffmann take care, Gerd