[edk2-platforms][PATCH v5 0/4] Resolving SecureBootVariableLib dependency

[edk2-platforms][PATCH v5 0/4] Resolving SecureBootVariableLib dependency

[Kun Qin]

This v5 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/92128

The v5 patches include a new `Reviewed-by` tag collected during the v4
round and skipped 2 patches merged during the last review cycle.

Patch v5 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v5

Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
Cc: Leif Lindholm<quic_llindhol@quicinc.com>
Cc: Graeme Gregory<graeme@nuviainc.com>
Cc: Radoslaw Biernacki<rad@semihalf.com>
Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
Cc: Nhi Pham<nhi@os.amperecomputing.com>
Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
Cc: Thang Nguyen<thang@os.amperecomputing.com>
Cc: Chuong Tran<chuong@os.amperecomputing.com>
Cc: Thomas Abraham<thomas.abraham@arm.com>
Cc: Sami Mujawar<sami.mujawar@arm.com>
Cc: Abner Chang<abner.chang@hpe.com>
Cc: Gilbert Chen<gilbert.chen@hpe.com>
Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
Cc: Jeremy Linton<jeremy.linton@arm.com>
Cc: Peng Xie<xiepeng@phytium.com.cn>
Cc: Ling Jia<jialing@phytium.com.cn>
Cc: Yiqi Shu<shuyiqi@phytium.com.cn>

Kun Qin (4):
  RaspberryPi: Platform Build: Resolving newly introduced dependency
  U5SeriesPkg: Platform Build: Resolving newly introduced dependency
  AmpereAltraPkg: Platform Build: Resolving newly introduced dependency
  PhytiumCommonPkg: Platform Build: Resolving newly introduced
    dependency

 Platform/RaspberryPi/RPi3/RPi3.dsc                                   | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc                                   | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                 | 1 +
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc            | 1 +
 6 files changed, 6 insertions(+)

-- 
2.37.1.windows.1

[edk2-platforms][PATCH v5 1/4] RaspberryPi: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
---

Notes:
    v2:
    - Add reviewed-by tag [Jeremy]
    
    v4:
    - Updated commit title.
    
    v5:
    - No change.

 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 0eed03c097f8..4e7377a00036 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -169,6 +169,7 @@ [LibraryClasses.common]
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index eabddd7382cf..8ba0ca61851e 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -166,6 +166,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v5 2/4] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com>
---

Notes:
    v2:
    - No review, no change
    
    v4:
    - Updated commit title.
    
    v5:
    - Added reviewed-by tag. [Daniel]

 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index 7b36b2c885e0..fc1ed012a541 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 26895a75ec2f..e59955d09452 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v5 3/4] AmpereAltraPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.

Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Vu Nguyen <vunguyen@os.amperecomputing.com>
Cc: Thang Nguyen <thang@os.amperecomputing.com>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
---

Notes:
    v2:
    - Added reviewed-by tag [Nhi]
    
    v4:
    - Updated commit title
    
    v5:
    - No change

 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index d4c29c3c338c..1e378e37e2b8 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -144,6 +144,7 @@ [LibraryClasses.common]
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   #
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
-- 
2.37.1.windows.1

[edk2-platforms][PATCH v5 4/4] PhytiumCommonPkg: Platform Build: Resolving newly introduced dependency

[Kun Qin]

The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Peng Xie <xiepeng@phytium.com.cn>
Cc: Ling Jia <jialing@phytium.com.cn>
Cc: Yiqi Shu <shuyiqi@phytium.com.cn>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v2:
    - No review, no change.
    
    v3:
    - Added reviewed-by tag [Sami].
    
    v4:
    - Updated commit title.
    
    v5:
    - No change.

 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index a7ca630be7b9..3c4440dac5f0 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -83,6 +83,7 @@ [LibraryClasses.common]
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
-- 
2.37.1.windows.1

Re: [edk2-platforms][PATCH v5 0/4] Resolving SecureBootVariableLib dependency

[Ard Biesheuvel]

On Mon, 15 Aug 2022 at 19:42, Kun Qin <kuqin12@gmail.com> wrote:
>
> This v5 series is a follow up of previously submitted patches:
> https://edk2.groups.io/g/devel/message/92128
>
> The v5 patches include a new `Reviewed-by` tag collected during the v4
> round and skipped 2 patches merged during the last review cycle.
>
> Patch v5 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v5
>
> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Graeme Gregory<graeme@nuviainc.com>
> Cc: Radoslaw Biernacki<rad@semihalf.com>
> Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
> Cc: Nhi Pham<nhi@os.amperecomputing.com>
> Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
> Cc: Thang Nguyen<thang@os.amperecomputing.com>
> Cc: Chuong Tran<chuong@os.amperecomputing.com>
> Cc: Thomas Abraham<thomas.abraham@arm.com>
> Cc: Sami Mujawar<sami.mujawar@arm.com>
> Cc: Abner Chang<abner.chang@hpe.com>
> Cc: Gilbert Chen<gilbert.chen@hpe.com>
> Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
> Cc: Jeremy Linton<jeremy.linton@arm.com>
> Cc: Peng Xie<xiepeng@phytium.com.cn>
> Cc: Ling Jia<jialing@phytium.com.cn>
> Cc: Yiqi Shu<shuyiqi@phytium.com.cn>
>
> Kun Qin (4):
>   RaspberryPi: Platform Build: Resolving newly introduced dependency
>   U5SeriesPkg: Platform Build: Resolving newly introduced dependency
>   AmpereAltraPkg: Platform Build: Resolving newly introduced dependency
>   PhytiumCommonPkg: Platform Build: Resolving newly introduced
>     dependency
>

Series pushed as d56523d0c1fa..6a847c32c0bb

Thanks,

Re: [edk2-platforms][PATCH v5 0/4] Resolving SecureBootVariableLib dependency

[Kun Qin]

Thank you so much for the help!

On 8/16/2022 10:54 AM, Ard Biesheuvel wrote:
> On Mon, 15 Aug 2022 at 19:42, Kun Qin <kuqin12@gmail.com> wrote:
>> This v5 series is a follow up of previously submitted patches:
>> https://edk2.groups.io/g/devel/message/92128
>>
>> The v5 patches include a new `Reviewed-by` tag collected during the v4
>> round and skipped 2 patches merged during the last review cycle.
>>
>> Patch v5 branch:https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep_v5
>>
>> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Graeme Gregory<graeme@nuviainc.com>
>> Cc: Radoslaw Biernacki<rad@semihalf.com>
>> Cc: Masami Hiramatsu<masami.hiramatsu@linaro.org>
>> Cc: Nhi Pham<nhi@os.amperecomputing.com>
>> Cc: Vu Nguyen<vunguyen@os.amperecomputing.com>
>> Cc: Thang Nguyen<thang@os.amperecomputing.com>
>> Cc: Chuong Tran<chuong@os.amperecomputing.com>
>> Cc: Thomas Abraham<thomas.abraham@arm.com>
>> Cc: Sami Mujawar<sami.mujawar@arm.com>
>> Cc: Abner Chang<abner.chang@hpe.com>
>> Cc: Gilbert Chen<gilbert.chen@hpe.com>
>> Cc: Daniel Schaefer<daniel.schaefer@hpe.com>
>> Cc: Jeremy Linton<jeremy.linton@arm.com>
>> Cc: Peng Xie<xiepeng@phytium.com.cn>
>> Cc: Ling Jia<jialing@phytium.com.cn>
>> Cc: Yiqi Shu<shuyiqi@phytium.com.cn>
>>
>> Kun Qin (4):
>>    RaspberryPi: Platform Build: Resolving newly introduced dependency
>>    U5SeriesPkg: Platform Build: Resolving newly introduced dependency
>>    AmpereAltraPkg: Platform Build: Resolving newly introduced dependency
>>    PhytiumCommonPkg: Platform Build: Resolving newly introduced
>>      dependency
>>
> Series pushed as d56523d0c1fa..6a847c32c0bb
>
> Thanks,