From: "Dimitrije Pavlov" <Dimitrije.Pavlov@arm.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Sunny Wang <Sunny.Wang@arm.com>,
Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Sunny Wang <sunny.wang@arm.com>
Subject: [PATCH v3 0/3] OvmfPkg: Check arguments for validity
Date: Tue, 16 Aug 2022 15:28:34 -0500 [thread overview]
Message-ID: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> (raw)
Some functions across OVMF don't check pointer arguments for
validity, which causes null pointer dereferences and crashes
in the SCT test suite.
This series adds checks to return EFI_INVALID_PARAMETER if a
pointer argument is NULL.
v3:
- Fix coding standard issues to pass CI checks [Ard]
v2: https://edk2.groups.io/g/devel/message/92443
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Sunny Wang <Sunny.Wang@arm.com>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Reviewed-by: Sunny Wang <sunny.wang@arm.com>
Dimitrije Pavlov (3):
OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments
OvmfPkg/VirtioGpuDxe: Check QueryMode arguments
OvmfPkg/VirtioFsDxe: Check GetDriverName arguments
OvmfPkg/PlatformDxe/Platform.c | 8 ++++++++
OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
OvmfPkg/VirtioGpuDxe/Gop.c | 5 ++++-
3 files changed, 16 insertions(+), 1 deletion(-)
--
2.37.2
next reply other threads:[~2022-08-16 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 20:28 Dimitrije Pavlov [this message]
2022-08-16 20:28 ` [PATCH v3 1/3] OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments Dimitrije Pavlov
2022-08-16 20:28 ` [PATCH v3 2/3] OvmfPkg/VirtioGpuDxe: Check QueryMode arguments Dimitrije Pavlov
2022-08-16 20:28 ` [PATCH v3 3/3] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments Dimitrije Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816202837.3257608-1-dimitrije.pavlov@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox