From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.20859.1660681724763059150 for ; Tue, 16 Aug 2022 13:28:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: dimitrije.pavlov@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54CDE153B; Tue, 16 Aug 2022 13:28:44 -0700 (PDT) Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B2D9C3F66F; Tue, 16 Aug 2022 13:28:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: [PATCH v3 3/3] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments Date: Tue, 16 Aug 2022 15:28:37 -0500 Message-Id: <20220816202837.3257608-4-dimitrije.pavlov@arm.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> References: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The current implementation does not check if Language or DriverName are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/Dr= iverBinding.c index 86eb9cf0ba51..69d2bb777089 100644 --- a/OvmfPkg/VirtioFsDxe/DriverBinding.c +++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c @@ -218,6 +218,10 @@ VirtioFsGetDriverName ( OUT CHAR16 **DriverName ) { + if ((Language =3D=3D NULL) || (DriverName =3D=3D NULL)) { + return EFI_INVALID_PARAMETER; + } + if (AsciiStrCmp (Language, "en") !=3D 0) { return EFI_UNSUPPORTED; } --=20 2.37.2