From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web12.15843.1661158296750344836
 for <devel@edk2.groups.io>;
 Mon, 22 Aug 2022 01:51:37 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aOOTq6KP;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1661158295;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qlaD5LXL9+cDioLjPW8ZEpPcIG088FIBVebK8F812/k=;
	b=aOOTq6KPc026co75JgJztTgk1HegzwchIPi8ddXVKVq+Pp3c1EGYQ+bIfWLtnZK9hrLxjX
	fxkpnc+rnugGkTy9tLuSD7rDAX5Ske92IGeHyQN/asPl9hr7nVHB8QlfFC86y1beRuI/Le
	LGU6a9sY9NjsrVltmRFygZnO/Iq1FT0=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-113-c6MAiP6kPveB0wj9wbVCtA-1; Mon, 22 Aug 2022 04:51:32 -0400
X-MC-Unique: c6MAiP6kPveB0wj9wbVCtA-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6571185A7BA;
	Mon, 22 Aug 2022 08:51:31 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.6])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 5661040D2830;
	Mon, 22 Aug 2022 08:51:31 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0B8141800082; Mon, 22 Aug 2022 10:51:30 +0200 (CEST)
Date: Mon, 22 Aug 2022 10:51:30 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA
Message-ID: <20220822085130.sdmuz3schsia4fxw@sirius.home.kraxel.org>
References: <20220822022301.1454-1-min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20220822022301.1454-1-min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 22, 2022 at 10:23:01AM +0800, Min Xu wrote:
> From: Min M Xu <min.m.xu@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974
> 
> Ovmf work-area (PcdOvmfWorkArea) was designed to store the Confidential
> Computing guest information, including the CC guest type. This
> information will be probed by CcProbeLib so that the CC guest type can
> be determined in run-time. But the Ovmf work-area was reserved as
> BT_Data so that it cannot be accessed after ExitBootService. Please see
> the detailed analysis in BZ#3974.
> 
> RH also reports a similar bug. Please see:
> https://bugzilla.redhat.com/show_bug.cgi?id=2114858
> 
> This patch reserves the work-area as RT_Data to fix this bug.

Seems to not be enough, I still see the page fault.
Maybe EfiConvertPointer() is needed at runtime?

take care,
  Gerd