From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, lersek@redhat.com,
Yuan Yu <yuanyu@google.com>, Pawel Polawski <ppolawsk@redhat.com>,
Oliver Steffen <osteffen@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
"Brian J . Johnson" <brian.johnson@hpe.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support
Date: Tue, 23 Aug 2022 09:04:36 +0200 [thread overview]
Message-ID: <20220823070436.dkc56uz66vfoj6wx@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAMj1kXFOsd7vOgY5h8eQMH5ZZNkDbqHYQr2f=5ozcVgzSKxtgw@mail.gmail.com>
Hi,
> > Looks good to me, but should be reflected to the other DSC files, and
> > perhaps (see Gerd's comments) factored out to some common include snippet.
>
> Fair enough, although I'm not sure where to look for Gerd's comments?
> Did they make it to the list?
Was a reply to v1 series.
Summary: We have alot of duplication in the Ovmf*.{dsc,fdf} files, I think
moving stuff to include files make sense (similar to OvmfTpm*.inc already in
tree) to reduce duplication, simplify maintainance and keep the build
configs in sync.
With more and more include snippets it possibly makes sense to move them
all into a subdirectory.
take care,
Gerd
next prev parent reply other threads:[~2022-08-23 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 15:11 [PATCH v2 0/2] Ovmf: Allow IPv4 and IPv6 to be disabled at runtime Ard Biesheuvel
2022-08-17 15:11 ` [PATCH v2 1/2] OvmfPkg: Introduce alternate UefiDriverEntrypoint to inhibit driver load Ard Biesheuvel
2022-08-18 5:58 ` Laszlo Ersek
2022-08-22 16:59 ` Ard Biesheuvel
2022-08-24 7:58 ` Laszlo Ersek
2022-08-17 15:11 ` [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support Ard Biesheuvel
2022-08-18 6:00 ` Laszlo Ersek
2022-08-22 17:00 ` [edk2-devel] " Ard Biesheuvel
2022-08-23 7:04 ` Gerd Hoffmann [this message]
2022-08-24 9:08 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823070436.dkc56uz66vfoj6wx@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox