From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.28454.1661238294303186377
 for <devel@edk2.groups.io>;
 Tue, 23 Aug 2022 00:04:55 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MUg2Hgdr;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1661238293;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QrrbdjTZ/WBZnWf/m9tYP3pzjrT90hgfq+dBVzXMbF4=;
	b=MUg2HgdrB1RnGFqkGCyK6DeUEjrawKWuOThNyphNdKlTiNiDVw56tePpWcJYUl7x6rUC/z
	k9xoz52BppPioYzabo+V+rt2r4MGXqnL9y/AmLOHmAawizgahcgeyfYydfUwgnbPZMI7xz
	QEAwvRvK98fPO6CVTehUbmh7rF/3c8Q=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-672-H3C5yjreOXGvsDjIgmHK5g-1; Tue, 23 Aug 2022 03:04:50 -0400
X-MC-Unique: H3C5yjreOXGvsDjIgmHK5g-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DBEAC1C16B40;
	Tue, 23 Aug 2022 07:04:49 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.6])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 93B53945D0;
	Tue, 23 Aug 2022 07:04:46 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id A08A1180039C; Tue, 23 Aug 2022 09:04:36 +0200 (CEST)
Date: Tue, 23 Aug 2022 09:04:36 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, lersek@redhat.com, Yuan Yu <yuanyu@google.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	"Brian J . Johnson" <brian.johnson@hpe.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support
Message-ID: <20220823070436.dkc56uz66vfoj6wx@sirius.home.kraxel.org>
References: <20220817151157.1941409-1-ardb@kernel.org>
 <20220817151157.1941409-3-ardb@kernel.org>
 <606fa379-1740-5353-d156-13069a5ba040@redhat.com>
 <CAMj1kXFOsd7vOgY5h8eQMH5ZZNkDbqHYQr2f=5ozcVgzSKxtgw@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMj1kXFOsd7vOgY5h8eQMH5ZZNkDbqHYQr2f=5ozcVgzSKxtgw@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > Looks good to me, but should be reflected to the other DSC files, and
> > perhaps (see Gerd's comments) factored out to some common include snippet.
> 
> Fair enough, although I'm not sure where to look for Gerd's comments?
> Did they make it to the list?

Was a reply to v1 series.

Summary: We have alot of duplication in the Ovmf*.{dsc,fdf} files, I think
moving stuff to include files make sense (similar to OvmfTpm*.inc already in
tree) to reduce duplication, simplify maintainance and keep the build
configs in sync.

With more and more include snippets it possibly makes sense to move them
all into a subdirectory.

take care,
  Gerd