From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.19973.1661399338815038538 for ; Wed, 24 Aug 2022 20:48:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=KK3tMSCH; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id C0D6F212599E; Wed, 24 Aug 2022 20:48:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C0D6F212599E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1661399338; bh=dnV6UpaipyKJVAh0bP3/poQ2bT3/FywvWCHGSixJKfc=; h=From:To:Cc:Subject:Date:From; b=KK3tMSCHq0PRACHPMiXKLMiJxhEYqjyNLAJzO7TRM+s1SMWZ1F3ANydONw7XcmczW XM1QBda9/ocVbW0Opr3VgCdIWHnIvKMxyxMZvOFnI78Q6i71qxCZJDq2V+rAH2NK7r +GBAzjbGgl6VdG41uB+PTv3kqFvkvCVtgkFwn39A= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Abner Chang , Alexei Fedorov , Ard Biesheuvel , Dandan Bi , David Woodhouse , Gerd Hoffmann , Guomin Jiang , Hao A Wu , Jian J Wang , Jiaxin Wu , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Maciej Rabeda , Nickle Wang , Qi Zhang , Rahul Kumar , Ray Ni , Sami Mujawar , Siyuan Fu Subject: [PATCH v2 0/8] Fix imbalanced debug macros Date: Wed, 24 Aug 2022 23:48:16 -0400 Message-Id: <20220825034824.4044-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki After noticing a few occurrences of DEBUG macros with a mismatched number of arguments, I wrote a script to automatically detect this. This patch series is the result of matches found by the script. In some cases it is not obvious what was originally intended so I have attempted to capture what I believe was the original author's intention. V2 Changes: These additional errors were found while finishing testing of the script. 1. Add DynamicTablesPkg/AcpiPpttLibArm patch for the change in - DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c 2. Update MdeModulePkg patch to include the change in - MdeModulePkg/Universal/CapsulePei/UefiCapsule.c 3. Add following to the RedfishPkg fix patch: - RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c - RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c 4. Add NetworkPkg patch for the change in - NetworkPkg/TcpDxe/SockInterface.c 5. Add OvmfPkg patch for the change in - OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c Cc: Abner Chang Cc: Alexei Fedorov Cc: Ard Biesheuvel Cc: Dandan Bi Cc: David Woodhouse Cc: Gerd Hoffmann Cc: Guomin Jiang Cc: Hao A Wu Cc: Jian J Wang Cc: Jiaxin Wu Cc: Jiewen Yao Cc: Jordan Justen Cc: Leif Lindholm Cc: Liming Gao Cc: Maciej Rabeda Cc: Nickle Wang Cc: Qi Zhang Cc: Rahul Kumar Cc: Ray Ni Cc: Sami Mujawar Cc: Siyuan Fu Signed-off-by: Michael Kubacki Michael Kubacki (8): ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier FatPkg/FatPei: Remove extraneous debug message argument MdeModulePkg: Fix imbalanced debug macros RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments NetworkPkg/TcpDxe: Fix debug macro arguments OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c = | 4 ++-- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c = | 3 +-- FatPkg/FatPei/Gpt.c = | 2 +- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c = | 2 +- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c = | 8 ++++---- MdeModulePkg/Core/Dxe/Image/Image.c = | 2 +- MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgr= essLibGraphics.c | 2 +- MdeModulePkg/Universal/CapsulePei/UefiCapsule.c = | 2 +- NetworkPkg/TcpDxe/SockInterface.c = | 12 ++---------- OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c = | 6 +++--- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c = | 6 +++--- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c = | 2 +- RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c = | 2 +- SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLib= Common.c | 2 +- 14 files changed, 23 insertions(+), 32 deletions(-) --=20 2.28.0.windows.1