From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.20068.1661399344424090520 for ; Wed, 24 Aug 2022 20:49:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Rl1tuB+8; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 7DA6B2125998; Wed, 24 Aug 2022 20:49:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7DA6B2125998 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1661399344; bh=U9FCm3hrjGJilZOSmFa3E45XvBWhM3h/zov/wPl1vSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rl1tuB+86DzJzzuEwVaBhHcgBVfUe2vCRTf++i5MpGw5SblqCgDjjqyEgWPwW8DdZ iI5yHegTKAy7CJgyQNijaSXvLPFmNECGJMHYITzDvrBxilj2N+T2muuQOgwyRHr/8P AhhZ8I3tNaAB1QzI73Nxk/qqF3sseo79YWcfDJL4= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Ard Biesheuvel Subject: [PATCH v2 1/8] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Date: Wed, 24 Aug 2022 23:48:17 -0400 Message-Id: <20220825034824.4044-2-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220825034824.4044-1-mikuback@linux.microsoft.com> References: <20220825034824.4044-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%ld, BufferSize=3D0x%= x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuvel --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/Ar= mPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c index 5afab0a79fa2..e671108e2bcf 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( Instance =3D INSTANCE_FROM_BLKIO_THIS (This); Media =3D This->Media; =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lb= a, BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, Buffe= rSizeInBytes, Buffer)); =20 if (!Media) { Status =3D EFI_INVALID_PARAMETER; @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( =20 Instance =3D INSTANCE_FROM_BLKIO_THIS (This); =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lb= a, BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D= %ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, Buffe= rSizeInBytes, Buffer)); =20 if ( !This->Media->MediaPresent ) { Status =3D EFI_NO_MEDIA; --=20 2.28.0.windows.1