From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.21931.1661419629948020371 for ; Thu, 25 Aug 2022 02:27:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SicZOR+7; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661419629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OiLR8I+kiTx9QjcNjK3yibtsnGeGkveuQETxvnglNa4=; b=SicZOR+7MWBSqUxU1dUoRpOv/AbjDFxrA23U55Px0YBxKMDDMuWaY+IZDXD2uoCwJsbtUX 4ptfi6d0vSN8MELNorz8MMqE2gLDfztH6xShI0rlMZz/F5QNfXp2ueLR7t8w+4BlIFG9r0 lfxCimd0ErzyhtWXsJHaf0N7yO1nanQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-0l7KH1vCPPqmbF-0kf0aWA-1; Thu, 25 Aug 2022 05:27:05 -0400 X-MC-Unique: 0l7KH1vCPPqmbF-0kf0aWA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8105E38164D0; Thu, 25 Aug 2022 09:27:05 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 470D42166B26; Thu, 25 Aug 2022 09:27:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D07AE1800082; Thu, 25 Aug 2022 11:27:03 +0200 (CEST) Date: Thu, 25 Aug 2022 11:27:03 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, ppolawsk@redhat.com Cc: Jian J Wang , Liming Gao Subject: Re: [[edk2-devel] PATH v1 1/3] MdeModulePkg: TerminalDxe: set xterm resolution on mode change Message-ID: <20220825092703.aedhmhi3aikh2m5a@sirius.home.kraxel.org> References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Aug 23, 2022 at 03:02:37AM +0200, Paweł Poławski wrote: > From: Laszlo Ersek > > Reference: > Signed-off-by: Laszlo Ersek > > Pawel: Updated commit message for re-submission > > Cc: Jian J Wang > Cc: Liming Gao > > Signed-off-by: Paweł Poławski > --- > MdeModulePkg/MdeModulePkg.dec | 4 +++ > MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 2 ++ > MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c | 30 ++++++++++++++++++++ > 3 files changed, 36 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 7d989108324a..45d793f3fddc 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -2098,6 +2098,10 @@ > # @Prompt The shared bit mask when Intel Tdx is enabled. > > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x10000025 > > > > + ## Controls whether TerminalDxe outputs an XTerm resize sequence on terminal > > + # mode change. Hmm, patch formating looks broken. Did you run BaseTools/Scripts/SetupGit.py? Otherwise the patch looks good to me. Acked-by: Gerd Hoffmann take care, Gerd