From: "gaoliming" <gaoliming@byosoft.com.cn>
To: devel@edk2.groups.io
Cc: Yuwei Chen <yuwei.chen@intel.com>, Bob Feng <bob.c.feng@intel.com>
Subject: [edk2-stable202208 3/3] Revert "BaseTools: Fix DSC LibraryClass precedence rule"
Date: Fri, 26 Aug 2022 10:14:56 +0800 [thread overview]
Message-ID: <20220826021456.2428-4-gaoliming@byosoft.com.cn> (raw)
In-Reply-To: <20220826021456.2428-1-gaoliming@byosoft.com.cn>
This reverts commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 for tag202208.
This brings the behavior changes, and needs more discussion.
Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 41f93c93f2..e9f68384b4 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -872,7 +872,7 @@ class DscBuildData(PlatformBuildClassObject):
if ModuleType != TAB_COMMON and ModuleType not in SUP_MODULE_LIST:
EdkLogger.error('build', OPTION_UNKNOWN, "Unknown module type [%s]" % ModuleType,
File=self.MetaFile, ExtraData=LibraryInstance, Line=LineNo)
- LibraryClassDict[ModuleType, Arch, LibraryClass] = LibraryInstance
+ LibraryClassDict[Arch, ModuleType, LibraryClass] = LibraryInstance
if LibraryInstance not in self._LibraryInstances:
self._LibraryInstances.append(LibraryInstance)
@@ -881,7 +881,7 @@ class DscBuildData(PlatformBuildClassObject):
for LibraryClass in LibraryClassSet:
# try all possible module types
for ModuleType in SUP_MODULE_LIST:
- LibraryInstance = LibraryClassDict[ModuleType, self._Arch, LibraryClass]
+ LibraryInstance = LibraryClassDict[self._Arch, ModuleType, LibraryClass]
if LibraryInstance is None:
continue
self._LibraryClasses[LibraryClass, ModuleType] = LibraryInstance
--
2.27.0.windows.1
next prev parent reply other threads:[~2022-08-26 2:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 2:14 [edk2-stable202208 0/3] Revert three patches for edk2 stable tag 202208 gaoliming
2022-08-26 2:14 ` [edk2-stable202208 1/3] Revert "UefiCpuPkg/CpuPageTableLib/UnitTest: Add host based unit test" gaoliming
2022-08-26 3:10 ` [edk2-devel] " Zhiguang Liu
2022-08-26 2:14 ` [edk2-stable202208 2/3] Revert "ShellPkg: Adds Local APIC parser to AcpiView" gaoliming
2022-08-26 2:14 ` gaoliming [this message]
2022-08-26 4:17 ` [edk2-devel] [edk2-stable202208 3/3] Revert "BaseTools: Fix DSC LibraryClass precedence rule" Bob Feng
2022-08-27 9:16 ` [edk2-devel] [edk2-stable202208 0/3] Revert three patches for edk2 stable tag 202208 Ard Biesheuvel
2022-08-29 2:48 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826021456.2428-4-gaoliming@byosoft.com.cn \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox