From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.33785.1661491415021960324
 for <devel@edk2.groups.io>;
 Thu, 25 Aug 2022 22:23:35 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B0BzppZK;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1661491413;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4yjYRGK1YOX6hinPm471/HMScHVwYw3vtzR8FTdHkuI=;
	b=B0BzppZK79oVr1O0RD9KM7dtg2sw5+qzQ8s1DJFMjGZ1lsKnSyXuSBkRO75E/3Nw35KrSy
	FHiniUzFnn76jjV189I6Sed7mMsp9fEzMSLxjC3tzb2dz+OMvzZsK+u5TNxCosKRBPCP6B
	N/xDfixIv7mQVFSZFFpcbvsgvDvTk1E=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-410-7f3vMcBzNiSbaVBxctWmVA-1; Fri, 26 Aug 2022 01:23:28 -0400
X-MC-Unique: 7f3vMcBzNiSbaVBxctWmVA-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 96A5229AB40D;
	Fri, 26 Aug 2022 05:23:27 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.82])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AA7B492C3B;
	Fri, 26 Aug 2022 05:23:27 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id F312B18003AB; Fri, 26 Aug 2022 07:23:25 +0200 (CEST)
Date: Fri, 26 Aug 2022 07:23:25 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V3 2/2] OvmfPkg: Update CcProbeLib to DxeCcProbeLib
Message-ID: <20220826052325.aiwch3qrbrnvj4mq@sirius.home.kraxel.org>
References: <cover.1661432416.git.min.m.xu@intel.com>
 <cda41a70360ad155233da0c0667817202f18ed4f.1661432416.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <cda41a70360ad155233da0c0667817202f18ed4f.1661432416.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> In DxeCcProbeLib we cache the GuestType in Ovmf work area in first-call.
> After that the Guest type is returned with the cached value. So that we
> don't need to worry about the access to Ovmf work area after
> ExitBootService.

This only works in case the first call is early enough.
Better use a CONSTRUCTOR instead.

take care,
  Gerd