From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.75]) by mx.groups.io with SMTP id smtpd.web12.35411.1661511397309285256 for ; Fri, 26 Aug 2022 03:56:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@suse.com header.s=selector1 header.b=f2Kl1YMV; spf=pass (domain: suse.com, ip: 40.107.20.75, mailfrom: jlee@suse.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWIizeqURfXupW+GHerqtL41pD5zbziEovjthN+QaSpmGM67EStUU4bawXs7QcEjSgAPtK/iBtqTfqcHnoP3X4EwsKyXYXOd8KzhM4/u+xylbzpvC2y5zRQ3/e/ChhkGdvutF6ug3iyuaFWqWv4O0oAzXRs3c+lSL3LgAaeJHRjqLcCpct+sq8zQmF9txIcVJPdRKgLjL+ha/vLph8VTbZl2yuuI/x8sn+FZTt2kwVeNB9Nh2bNAdCMOVANmYNYsRBDVMunlTAnkcxkYoxhWo3qtDxaHZYnxEeY7a3wGSF0OUKJc4G0q7bwoKivB/yfn1Vc1HrN02vkKblsjeWUN+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aFZDOB/5BhUEDMTcW/D4Voh4sshMhSo6QK2DoFJ+t4g=; b=FB2Tr9UOoRiTGcnLLGhsRt8WK1BISBS8cuOWewNQYJOCJeZ02FqJvrYyEmGQ7/y7LzOAsbxzsjWSvLJJAKhx42XMtpxS3OLhW4YZI12PIBivxV1inbifxs+uCINDTLY4l2fLT02RgTUUxo08Aoo8TbnXmazHKKwQLDkpE+JEKtvbarcrfKVyITkqWcsqqjyTkCqxKPFDkrSBZTzxRuULF170C9DcSaPHvgtj/HkFbabGaGdtglciOQ2D2SIX7sYshrsDI0hNi7F4rLHGXvuEQU4ZcBHtCSNyLX/oYkX3SAXde8wDgNktoY7YYPMgHu7PbxBvgPkg2pdkiVL75vQMdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aFZDOB/5BhUEDMTcW/D4Voh4sshMhSo6QK2DoFJ+t4g=; b=f2Kl1YMV+iPtn3U1cwuCkszQKd8/wlpAAYuRUM1dimxp73RSoPFVN7kDhZsQoNwUUM08VxpcBuoPy9mTjs6ncqxcHxYhUVSPNAqCBAk8bL6W39FCjWH9pdu5rWTRHXMULWEc4cjq/V5mNUfmMIDDkXKDKkGji6P4be8bp+Bx+CPtl0+e3Au1bOQQog1/UxU52P7Uu90yDDbdbnzTShITeXyWnUzioW4ggLlGg3vFkHN3oC7RMiu4Vq2SBAbqcSKxlZMGtHDP8XzhO1Bzve/M4e2S4Ai3ooPSuVUMicsJA6OgIodiui1uhfQIL0hnJIVsjqoqS7PA/X46r5nLX0SEqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) by HE1PR04MB3258.eurprd04.prod.outlook.com (2603:10a6:7:25::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 26 Aug 2022 10:56:34 +0000 Received: from DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::c1b3:1b0c:46fc:4b2b]) by DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::c1b3:1b0c:46fc:4b2b%3]) with mapi id 15.20.5566.015; Fri, 26 Aug 2022 10:56:33 +0000 Date: Fri, 26 Aug 2022 18:56:20 +0800 From: "joeyli" To: Gerd Hoffmann Cc: "Lee, Chun-Yi" , devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Min Xu , Brijesh Singh , Erdem Aktas , James Bottomley Subject: Re: [PATCH] OvmfPkg/IncompatiblePciDeviceSupportDxe: Ignore OptionRom in Sev guest Message-ID: <20220826105620.GO5247@linux-l9pv.suse> References: <20220825133925.6410-1-jlee@suse.com> <20220826052717.gqbympdx7a367vqo@sirius.home.kraxel.org> In-Reply-To: <20220826052717.gqbympdx7a367vqo@sirius.home.kraxel.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-ClientProxiedBy: TYCPR01CA0002.jpnprd01.prod.outlook.com (2603:1096:405::14) To DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) Return-Path: JLee@suse.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9cb85af8-4d49-4bad-7b35-08da8751a3a6 X-MS-TrafficTypeDiagnostic: HE1PR04MB3258:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dQE+Y446bG6/TrBMqb9ZF+r+1f+aQyNtc6RBdnbClbCZLgroVZH5WEfEmKQ6kjXAydPjgFC+TfUaUcg60kUIRfmhK86keb4Qr6dSC/CD6f76aq4c//kjY9aU0JJT/8BXPJF0MPr866K78XJjjEnvZ/cx8qeGsdpH5fd2f8u/kfwYal59Nux9fgDvD1qnjr46Ej8iHk2Zz0Qf4zXQeEHk0NVnaWk6eewaEGr9TyPFZyP/92Kl/vS6U3z2HX2626EJnAN+nYnm94JaTgnMgKSMT8BFlSn/3eYOBLEGCv3LOJq57YLR4rrce31eF+8rWB/a3EkgI7ZsAoti6XwdReaDtFdWXU5umap/N9w5q6zhiQmSdZYl2iVNTvvWxLwP8bzdyfNuXfNdJ2n7JuZUSo9vrTY+5SLkvcYduU8t3g0AYVP6D/7ciBtWJnR0z+qxMbASTVeLIHsX/nbYN63lieKmAJ459BkeY8v3IGdKcXlOHRZi9iFOgrHBAp8C5/EgJL4mZb32trXJOHxUTvOQCpsSfBM7J8T1hChUhmYpzwN/lGS93J1+t60N4BWNm0ur4TLdSG+AVPU3HToAq8v63DtQYqf4P3C8vvn1ZjloHOz2Tp86QZCFsNiYXEjjmNJVsOtWLQQ6alqqpQslRNxR3QY6v7hWc+JXMhSPgxpW6WW2LfztewghlBtRHpiiUmkMZ9iGy15uxt7TIGb45VNo0XPWphEkA2WmaKhjr5b+FMOHtA+zEbU1Zyn3bgEmx1hbXHtvK4ouRYQBG7i1tiiv3rcuMpeEeZugTSfbQSMVKO0RnzlCwpQB9pviMpKIFyk4JuY/mvdIxShy0g4DjfczXVCAXg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR04MB7164.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(376002)(396003)(346002)(6666004)(54906003)(6512007)(7416002)(6506007)(2906002)(86362001)(5660300002)(41300700001)(4744005)(9686003)(186003)(1076003)(36756003)(6916009)(8676002)(66946007)(66556008)(4326008)(8936002)(6486002)(33656002)(316002)(38100700002)(66476007)(478600001)(43062005)(213903007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/mDS+UZUB0r7VxmmNJQNnFhD0bjvUJTwTQU5Whor6vp63M+zvFT3M2KR9Fm6?= =?us-ascii?Q?/QgBpjcNlci9E+qG3FmP6AA41tx74RofMoYXhAcFojBECc1ADU+kwXcX/xF+?= =?us-ascii?Q?wgALa2QEE2q0N+0VdpC61d6dJdXcaxnpUhRfR49HzpjD0/EWEE694IDvfZ2K?= =?us-ascii?Q?CL7hAQL2NjzmDfGc9WHrwuiENrce+Klz4G5R4jadVjFq9qpKk+JPp4Zu6Re3?= =?us-ascii?Q?En0BrhkUfr69Zi2780xeTK84FSojNZEIlGRT/S8LtsUvaCwbNOIgWz+nXlAL?= =?us-ascii?Q?amh5KzFAAkC/BKLXqaRLYG0BfAvSr0VIaPakcEqrPPhBCJPh2JC3Gd4L7upC?= =?us-ascii?Q?F6nRmanqIEccIBNyTXCCM0m8nr3hFPLBbNHqyxVj+TtaEFE3srbXJ8MmMjpe?= =?us-ascii?Q?NvMn9TL/uKDI0eKKedjqPj2MURM+D7s99NQE4mQGCSRE9qCNdeBoU15qpxF6?= =?us-ascii?Q?RXWJzjEOFGtwCIdcA//z7eusc00GVNCGSjLQA3Jnp67/wpeONQTAtGUE6rE7?= =?us-ascii?Q?ptOgIQusoaV9feZF9x18lfrR9DYVX1ACRk5eHmcqhrOA6mvBc+81hu0Ks5/u?= =?us-ascii?Q?qxicNmgqsorB2Im8Te7VhTZH16RUyPy0VfbGFCgLnw7GQU2iLOuDyndyPYjy?= =?us-ascii?Q?hH1KVyrCXKCPpacHvqkddUjzd0GJLg9BCoPfRvDkPo7Y7JPP7/pKslgFxaku?= =?us-ascii?Q?ueb62o+vC51yTOgiiomJkJ4qLj84iORz4/Nr3V8+7UrXhssyp/WkY0zC3rHU?= =?us-ascii?Q?UWhamEnf5hc1QGryXiZOzprAJJx5nSBgcj3taum/MRLvD8qR/+OwQ7QG/ruB?= =?us-ascii?Q?NbbPvyEAn0NL8KeVHdMroZTkIXRFoa3gDqk881b9WV4bBcydMd/RZGaydHZ/?= =?us-ascii?Q?Y4GME34O29bl+7VM1hIBrCRJpbjS7fDvJwidxVpg5yKnmRNLgMjLT1spDE5z?= =?us-ascii?Q?2cAbEjpjzU59ERHXvkd0YhPQfy/BFg7Fd6lk4BNnc3C4Jn8rU7C5ki//iqRf?= =?us-ascii?Q?jTeU0obN0AP0mOLfko6JO6uswm1MC/tEjDM80VA1A8R1jNzObmHiwncFtnbF?= =?us-ascii?Q?xl3hVFWxxQqCG9JcmWCpjbwaBnaw/2HFOBWp4Wi0un3BIh9ug+zQWeX0QYkt?= =?us-ascii?Q?MtfW+RSEj+tqA1glB/NWq9mlcgChCr0JKxU8BhtdUa00u9D1cpULqyFqpU1W?= =?us-ascii?Q?mtZ7+uqzn/2iRrx4WLKK4PcjNSB75NvgEa/y5OT0RG7A5WPBbm8aWaawJxGx?= =?us-ascii?Q?t/GfJzYjAEK8Z1w/XxTmUOtTk0KaqQGMIenjBphdbDbnyw2fxko61Cpg516Q?= =?us-ascii?Q?gQ3FPgokR05PIjAG0OD84elax0J2duZ9hWNQ/b4YiGHa5s57+zfbcdy2QBKV?= =?us-ascii?Q?hEhNu2HBL9mBcwfyXI0E+XODRN2Xu/hSqwjH0lRtLcvGsxwu7dOfYN4u1axQ?= =?us-ascii?Q?MpXD9u9QQP2R+XU6jJjCA+WuKQUx7OKLM537K6ullR6kH5NSJrNl+fYgQfTp?= =?us-ascii?Q?PRX/qPmCamSyEDwKi8W7J44+dUAcNKa0lVWtSXPUgOCUZZ7MMC1O945KKepB?= =?us-ascii?Q?5wpFLGAxR/mvjQ0Q9QaHuA+ltmqI6h2hdxdyvXz5a82P0DoqrGcfmB9L3Giw?= =?us-ascii?Q?+5YkY/JO6weWEhD90uOjvGo=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cb85af8-4d49-4bad-7b35-08da8751a3a6 X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 10:56:33.6231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3p98UloWWi7qd1FcsfRbD2iOSryBOQSTiaGSlbAfLjhvHp8MUEtjpxQdz3tih4SZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3258 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Gerd, On Fri, Aug 26, 2022 at 07:27:17AM +0200, Gerd Hoffmann wrote: > Hi, > > > - if (TdIsEnabled ()) { > > + if (TdIsEnabled () || MemEncryptSevIsEnabled()) { > > I think you can just use CcProbeLib and CcProbe() function to cover both > tdx and sev. > Thanks for your review and suggestion! It works to me. I will send version 2 patch. Joey Lee