From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web08.9743.1661854489139790730 for ; Tue, 30 Aug 2022 03:14:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XYE5CR5w; spf=pass (domain: gmail.com, ip: 209.85.167.45, mailfrom: aladyshev22@gmail.com) Received: by mail-lf1-f45.google.com with SMTP id j14so4503794lfu.4 for ; Tue, 30 Aug 2022 03:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=e8kOe68bmczwWbbxxrL83VCxxnJed9kyJDHMDfxneBw=; b=XYE5CR5wXKFuafpseNMDCGh1IWtWT/wnqpa4CyAIEH4bNjPnOZecqBnFiO8ba0kkUi 0vs1liICFrglLtZsmMNdMZRCEEvjre4/GEjjN00ALskQBp2NLrf+Jy2uqGz1ZyNsdeZp MNbOVSbV2H7uEMvxpzey1w8EEZqo7lt3tp5IxfMq2t9ipW+Yfo4+dI12IwcEaDMLIjm+ siUUMat3drxxXnx8wbFLXfYKC7EAbWel/RC2pT0k/huncbsCQwbktiVf9f2ijEqSlFdQ jRvm3gx+4SgiCSs2d4DeVS85BbI8C9NALgWQfMivmh/HlAHARcwY8MbI/dUf9RI/9RR1 /i/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=e8kOe68bmczwWbbxxrL83VCxxnJed9kyJDHMDfxneBw=; b=zIZlhovqtARmIj1XLo5GwLYiaEsj+++SHtwPe1T6ysjr8CFlZydHrQO2M9UCPGTHKO gulsxnsBqfY4XyZRxunPEE6/XYOFLuH/QADQQmDvQpx+/JGUSaiZqMrV/vbAa0Mjz4QF Qg+AZrR7Dcq+shSMpe/eTH7pyi6me+9uJf1YH+c0k/+Y2qv08mNOIybOmWKB5PxsvFtz +LONWgvvTWeEWKckVCznTTjs2hivUWjMiTChYRuHE+P2kBHS0H07/gf52UgrJAx98foL mRK490ZZTMo9c8gb+DaLhHqEvQmeu+FdPSnTIwrkHFcLd322Fd0YzUN9p367YAcw59sm zPlw== X-Gm-Message-State: ACgBeo3mv/4gBvjM5rmNqCSWThE5MejyNbl31iZjgwfH0im9y1pGQvk2 RSbFJXg0ZJkDIMLGPG/x4KaSgo7+/Qo= X-Google-Smtp-Source: AA6agR6WFefxY8Eu7UvA4n5CMTbrvgsaK/GeZDj6ri1OmWGwIG7OZMn2aFW5nw97xENtCDVnKV7hvA== X-Received: by 2002:a05:6512:31d0:b0:492:fe2e:7695 with SMTP id j16-20020a05651231d000b00492fe2e7695mr8312192lfe.392.1661854487208; Tue, 30 Aug 2022 03:14:47 -0700 (PDT) Return-Path: Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id u9-20020a05651c130900b0026008acb55asm1716755lja.113.2022.08.30.03.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 03:14:46 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, Konstantin Aladyshev Subject: [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing Date: Tue, 30 Aug 2022 13:14:40 +0300 Message-Id: <20220830101445.18110-1-aladyshev22@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Currently 'PutFileImage' function is called with arguments that are not advanced on each section parsing. This would lead to an error if EFI_SECTION_GUID_DEFINED is not the first in a file. The same mistake is present in the parsing of CRC32 guided section case. Use correct arguments to fix the issue. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/VolInfo/VolInfo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolI= nfo/VolInfo.c index 135924e028..b5760d185e 100644 --- a/BaseTools/Source/C/VolInfo/VolInfo.c +++ b/BaseTools/Source/C/VolInfo/VolInfo.c @@ -2012,8 +2012,8 @@ Returns: Status =3D=0D PutFileImage (=0D ToolInputFile,=0D - (CHAR8*) SectionBuffer + DataOffset,=0D - BufferLength - DataOffset=0D + (CHAR8*)Ptr + DataOffset,=0D + SectionLength - DataOffset=0D );=0D =0D system (SystemCommand);=0D @@ -2058,8 +2058,8 @@ Returns: //=0D printf ("/------------ Encapsulation section start ---------------= --\\\n");=0D Status =3D ParseSection (=0D - SectionBuffer + DataOffset,=0D - BufferLength - DataOffset=0D + Ptr + DataOffset,=0D + SectionLength - DataOffset=0D );=0D if (EFI_ERROR (Status)) {=0D Error (NULL, 0, 0003, "parse of CRC32 GUIDED section failed", NU= LL);=0D --=20 2.25.1