From: "Konstantin Aladyshev" <aladyshev22@gmail.com>
To: devel@edk2.groups.io
Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn,
yuwei.chen@intel.com,
Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH 3/6] BaseTools/VolInfo: Increase GUID base name string
Date: Tue, 30 Aug 2022 13:14:42 +0300 [thread overview]
Message-ID: <20220830101445.18110-3-aladyshev22@gmail.com> (raw)
In-Reply-To: <20220830101445.18110-1-aladyshev22@gmail.com>
The current string lenght (=60) is not enough for cases where basename
is a path to Build folder.
Drop custom define and use MAX_LINE_LEN from the BaseTools codebase
instead.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
BaseTools/Source/C/VolInfo/VolInfo.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolInfo/VolInfo.c
index 4628e756d7..d9be3d8c18 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.c
+++ b/BaseTools/Source/C/VolInfo/VolInfo.c
@@ -51,15 +51,13 @@ EFI_GUID gEfiCrc32GuidedSectionExtractionProtocolGuid = EFI_CRC32_GUIDED_SECTIO
#define EFI_SECTION_ERROR EFIERR (100)
-#define MAX_BASENAME_LEN 60 // not good to hardcode, but let's be reasonable
-
//
// Structure to keep a list of guid-to-basenames
//
typedef struct _GUID_TO_BASENAME {
struct _GUID_TO_BASENAME *Next;
INT8 Guid[PRINTED_GUID_BUFFER_SIZE];
- INT8 BaseName[MAX_BASENAME_LEN];
+ INT8 BaseName[MAX_LINE_LEN];
} GUID_TO_BASENAME;
static GUID_TO_BASENAME *mGuidBaseNameList = NULL;
--
2.25.1
next prev parent reply other threads:[~2022-08-30 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 10:14 [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing Konstantin Aladyshev
2022-08-30 10:14 ` [PATCH 2/6] BaseTools/VolInfo: Correct buffer for GenCrc32 tool Konstantin Aladyshev
2022-09-27 2:50 ` 回复: " gaoliming
2022-08-30 10:14 ` Konstantin Aladyshev [this message]
2022-09-26 5:25 ` 回复: [edk2-devel] [PATCH 3/6] BaseTools/VolInfo: Increase GUID base name string gaoliming
2022-08-30 10:14 ` [PATCH 4/6] BaseTools/VolInfo: Update file and section type strings Konstantin Aladyshev
2022-09-26 5:26 ` 回复: [edk2-devel] " gaoliming
2022-08-30 10:14 ` [PATCH 5/6] BaseTools/VolInfo: Parse apriori files Konstantin Aladyshev
2022-09-26 5:27 ` 回复: [edk2-devel] " gaoliming
2022-08-30 10:14 ` [PATCH 6/6] BaseTools/VolInfo: Update copyright information Konstantin Aladyshev
2022-09-26 5:27 ` 回复: [edk2-devel] " gaoliming
2022-08-31 1:43 ` 回复: [edk2-devel] [PATCH 1/6] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing gaoliming
2022-10-01 15:15 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830101445.18110-3-aladyshev22@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox