From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Bob Feng <bob.c.feng@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Yuwei Chen <yuwei.chen@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [PATCH 1/1] OvmfPkg: Add BUILD_SHELL flag for IA32, IA32X64, X64
Date: Thu, 1 Sep 2022 18:08:41 +0200 [thread overview]
Message-ID: <20220901160841.rmqghzrhnvrii7h6@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220830161354.310462-1-osteffen@redhat.com>
On Tue, Aug 30, 2022 at 06:13:54PM +0200, Oliver Steffen wrote:
> Add BUILD_SHELL flag, similar to the one in OvmfPkg/AmdSev,
> to enable/disable building of the UefiShell as part of
> the firmware image. The UefiShell should not be included for
> secure production systems (e.g. SecureBoot) because it can be
> used to circumvent security features.
>
> The default value for BUILD_SHELL is TRUE to keep the default
> behavior of the Ovmf build.
> Note: the default for AmdSev is FALSE.
>
> The BUILD_SHELL flag for AmdSev was introduced in b261a30c900a8.
Looks good to me and makes the files more consistent.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2022-09-01 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 16:13 [PATCH 1/1] OvmfPkg: Add BUILD_SHELL flag for IA32, IA32X64, X64 Oliver Steffen
2022-09-01 16:08 ` Gerd Hoffmann [this message]
2022-09-05 13:53 ` [edk2-devel] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901160841.rmqghzrhnvrii7h6@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox