From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.14276.1662048525853558927
 for <devel@edk2.groups.io>;
 Thu, 01 Sep 2022 09:08:46 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gPO72V9h;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1662048525;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=501CN+7z9EowS4z7lrfafO3p2nJ1fNLHP8o5KNP+zOg=;
	b=gPO72V9h8JAqDff5kzX+vvjLtBNsFecHTP7ZkvIi27wolnbTgMQW8FRPI2bupRyuduVy4l
	X7FjZeI3bEa2Ukna097FQp8vDntnVMF+bmEONz6G/ApNn3EkW14LCjTEpSgsmQ8rO088DH
	FmostENpCK+ZqGk5wxCN4asl7thsx04=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-347-JwEltsF5N_uyp_yLDKkaug-1; Thu, 01 Sep 2022 12:08:43 -0400
X-MC-Unique: JwEltsF5N_uyp_yLDKkaug-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5500D3C10233;
	Thu,  1 Sep 2022 16:08:43 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.195.70])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B9F4492C3B;
	Thu,  1 Sep 2022 16:08:43 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 41C9C18003AA; Thu,  1 Sep 2022 18:08:41 +0200 (CEST)
Date: Thu, 1 Sep 2022 18:08:41 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Oliver Steffen <osteffen@redhat.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Bob Feng <bob.c.feng@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [PATCH 1/1] OvmfPkg: Add BUILD_SHELL flag for IA32, IA32X64, X64
Message-ID: <20220901160841.rmqghzrhnvrii7h6@sirius.home.kraxel.org>
References: <20220830161354.310462-1-osteffen@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20220830161354.310462-1-osteffen@redhat.com>
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 30, 2022 at 06:13:54PM +0200, Oliver Steffen wrote:
> Add BUILD_SHELL flag, similar to the one in OvmfPkg/AmdSev,
> to enable/disable building of the UefiShell as part of
> the firmware image. The UefiShell should not be included for
> secure production systems (e.g. SecureBoot) because it can be
> used to circumvent security features.
> 
> The default value for BUILD_SHELL is TRUE to keep the default
> behavior of the Ovmf build.
> Note: the default for AmdSev is FALSE.
> 
> The BUILD_SHELL flag for AmdSev was introduced in b261a30c900a8.

Looks good to me and makes the files more consistent.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd