From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Théo <theojehl76@gmail.com>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Isaac Oram <isaac.w.oram@intel.com>,
Pedro Falcato <pedro.falcato@gmail.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [edk2-platforms][PATCH v1 01/02] QemuOpenBoardPkg: Add QemuOpenBoardPkg
Date: Fri, 2 Sep 2022 12:02:45 +0200 [thread overview]
Message-ID: <20220902100245.m5mgcpvub4gmwj54@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220827000201.22235-2-theojehl76@gmail.com>
On Sat, Aug 27, 2022 at 02:02:00AM +0200, Théo wrote:
> From: Théo Jehl <theojehl76@gmail.com>
>
> QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64
> It can boots UEFI Linux and Windows, and works on PIIX4 and Q35
> This board port provides a simple starting place for investigating edk2 and
> MinPlatform Arch.
> Currently we implement up to stage 4 of the MinPlatform spec and can boot
> Windows/Linux.
That is a rather short description for a patch of this size. It
probably makes sense to break that down into smaller pieces and make a
patch series out of it because you can describe the specific pieces much
better then.
I'm not familiar with MinPlatform, just skimmed the manual. Can't
comment much on those details.
It seems the goal is to have a MinPlatform board which can easily be
used to learn about and experiment with MinPlatform, is that correct?
> Platform/Qemu/QemuOpenBoardPkg/Library/OpenQemuFwCfgLib/OpenQemuFwCfgLib.inf | 23 +
> Platform/Qemu/QemuOpenBoardPkg/Include/Library/OpenQemuFwCfgLib.h | 102 +++
> Platform/Qemu/QemuOpenBoardPkg/Library/OpenQemuFwCfgLib/OpenQemuFwCfgLib.c | 130 ++++
Why duplicate that lib instead of just using the OvmfPkg version (which
you do elsewhere)?
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Cpu.c | 56 ++
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c | 244 ++++++++
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pci.c | 59 ++
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c | 91 +++
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/PlatformInit.c | 67 ++
Note that OvmfPkg got a PlatformInitLib recently which you might be able
to use to reduce code duplication (didn't check the code though and
maybe MinPlatform init is different enough that this doesn't help much).
take care,
Gerd
next prev parent reply other threads:[~2022-09-02 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 0:01 [edk2-platforms][PATCH v1 00/02] Add QemuOpenBoardPkg Théo Jehl
2022-08-27 0:02 ` [edk2-platforms][PATCH v1 01/02] QemuOpenBoardPkg: " Théo Jehl
2022-08-29 21:41 ` Pedro Falcato
2022-09-02 10:02 ` Gerd Hoffmann [this message]
2022-09-02 13:36 ` Théo Jehl
2022-09-02 16:49 ` Gerd Hoffmann
2022-09-02 16:51 ` Pedro Falcato
2022-08-27 0:02 ` [edk2-platforms][PATCH v1 02/02] Maintainers: Add maintainers for QemuOpenBoardPkg Théo Jehl
2022-08-29 20:15 ` [edk2-devel] [edk2-platforms][PATCH v1 00/02] Add QemuOpenBoardPkg Oram, Isaac W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902100245.m5mgcpvub4gmwj54@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox