From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.4790.1662112976454937832 for ; Fri, 02 Sep 2022 03:02:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T3c/XEsl; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662112974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z3R4JPINBHTGfrbVy7zznuqkwPXLVvbGkREqcq6YsGc=; b=T3c/XEslxGFwGjtzzTVT08diPi1hOUdGSjB0u1QNFriJRebeyIrFRaQiR+yS/jJMULAQUQ OD+2O+SN4BMOwv0LwOi6ctFtz/wDxTdxntz6dXlArWbkTYeWOuZTeoFFarphpMWWS0tZBo v8bHh35KTFzz21TH4D9Ax/S56rG1i8Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-76-SiYQweDCNN-fPzeTtBqRxQ-1; Fri, 02 Sep 2022 06:02:48 -0400 X-MC-Unique: SiYQweDCNN-fPzeTtBqRxQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2ED3C2806AA0; Fri, 2 Sep 2022 10:02:48 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.195.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3D23492C3B; Fri, 2 Sep 2022 10:02:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D5D8F18003AA; Fri, 2 Sep 2022 12:02:45 +0200 (CEST) Date: Fri, 2 Sep 2022 12:02:45 +0200 From: "Gerd Hoffmann" To: =?utf-8?B?VGjDqW8=?= Cc: devel@edk2.groups.io, Leif Lindholm , Michael D Kinney , Isaac Oram , Pedro Falcato , Stefan Hajnoczi Subject: Re: [edk2-platforms][PATCH v1 01/02] QemuOpenBoardPkg: Add QemuOpenBoardPkg Message-ID: <20220902100245.m5mgcpvub4gmwj54@sirius.home.kraxel.org> References: <20220827000201.22235-1-theojehl76@gmail.com> <20220827000201.22235-2-theojehl76@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220827000201.22235-2-theojehl76@gmail.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Aug 27, 2022 at 02:02:00AM +0200, Théo wrote: > From: Théo Jehl > > QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64 > It can boots UEFI Linux and Windows, and works on PIIX4 and Q35 > This board port provides a simple starting place for investigating edk2 and > MinPlatform Arch. > Currently we implement up to stage 4 of the MinPlatform spec and can boot > Windows/Linux. That is a rather short description for a patch of this size. It probably makes sense to break that down into smaller pieces and make a patch series out of it because you can describe the specific pieces much better then. I'm not familiar with MinPlatform, just skimmed the manual. Can't comment much on those details. It seems the goal is to have a MinPlatform board which can easily be used to learn about and experiment with MinPlatform, is that correct? > Platform/Qemu/QemuOpenBoardPkg/Library/OpenQemuFwCfgLib/OpenQemuFwCfgLib.inf | 23 + > Platform/Qemu/QemuOpenBoardPkg/Include/Library/OpenQemuFwCfgLib.h | 102 +++ > Platform/Qemu/QemuOpenBoardPkg/Library/OpenQemuFwCfgLib/OpenQemuFwCfgLib.c | 130 ++++ Why duplicate that lib instead of just using the OvmfPkg version (which you do elsewhere)? > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Cpu.c | 56 ++ > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c | 244 ++++++++ > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pci.c | 59 ++ > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c | 91 +++ > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/PlatformInit.c | 67 ++ Note that OvmfPkg got a PlatformInitLib recently which you might be able to use to reduce code duplication (didn't check the code though and maybe MinPlatform init is different enough that this doesn't help much). take care, Gerd