From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Abner Chang <abner.chang@amd.com>, Nickle Wang <nickle.wang@hpe.com>
Subject: [PATCH v3 4/8] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument
Date: Fri, 2 Sep 2022 18:22:02 -0400 [thread overview]
Message-ID: <20220902222206.1509-5-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com>
From: Michael Kubacki <michael.kubacki@microsoft.com>
The debug macro argument in this change is removed since it does
have a corresponding print specifier in the debug message string.
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 6 +++---
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 2 +-
RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
index bf50c78c9280..586ecfadc715 100644
--- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
+++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
@@ -264,12 +264,12 @@ Tcp6GetSubnetInfo (
Status = Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL);
if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n"));
+ DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __FUNCTION__));
return Status;
}
if (IpModedata.AddressCount == 0) {
- DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n"));
+ DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __FUNCTION__));
}
if (Instance->SubnetAddrInfoIPv6 != NULL) {
@@ -278,7 +278,7 @@ Tcp6GetSubnetInfo (
Instance->SubnetAddrInfoIPv6 = AllocateZeroPool (IpModedata.AddressCount * sizeof (EFI_IP6_ADDRESS_INFO));
if (Instance->SubnetAddrInfoIPv6 == NULL) {
- DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory fir IPv6 subnet address information\n"));
+ DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory for IPv6 subnet address information\n", __FUNCTION__));
return EFI_OUT_OF_RESOURCES;
}
diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
index 8a05764ac605..623350bc261c 100644
--- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
+++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
@@ -119,7 +119,7 @@ RedfishCreateSmbiosTable42 (
} else {
NewProtocolRecords = ReallocatePool (CurrentProtocolsDataLength, NewProtocolsDataLength, (VOID *)ProtocolRecords);
if (NewProtocolRecords == NULL) {
- DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish host interface protocol data."));
+ DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish host interface protocol data.", __FUNCTION__));
FreePool (ProtocolRecords);
FreePool (ProtocolRecord);
return EFI_OUT_OF_RESOURCES;
diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
index f224104ad673..4b61fc01adc4 100644
--- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
+++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
@@ -224,7 +224,7 @@ ReSendRequest:;
DEBUG ((DEBUG_INFO, "HTTP_STATUS_200_OK\n"));
if (SendChunkProcess == HttpIoSendChunkHeaderZeroContent) {
- DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunks.", ResponseData->Response.StatusCode));
+ DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunks."));
SendChunkProcess++;
goto ReSendRequest;
}
--
2.28.0.windows.1
next prev parent reply other threads:[~2022-09-02 22:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 22:21 [PATCH v3 0/8] Fix imbalanced debug macros Michael Kubacki
2022-09-02 22:21 ` [PATCH v3 1/8] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Michael Kubacki
2022-09-02 22:22 ` [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument Michael Kubacki
2022-09-02 22:22 ` [PATCH v3 3/8] MdeModulePkg: Fix imbalanced debug macros Michael Kubacki
2022-09-02 22:22 ` Michael Kubacki [this message]
2022-09-05 7:20 ` [edk2-devel] [PATCH v3 4/8] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument nickle
2022-09-02 22:22 ` [PATCH v3 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Michael Kubacki
2022-09-02 22:22 ` [PATCH v3 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments Michael Kubacki
2022-09-02 22:22 ` [PATCH v3 7/8] NetworkPkg/TcpDxe: " Michael Kubacki
2022-09-02 22:22 ` [PATCH v3 8/8] OvmfPkg/LegacyBootManagerLib: " Michael Kubacki
2022-09-05 6:24 ` Gerd Hoffmann
2022-09-05 7:53 ` Ard Biesheuvel
[not found] ` <17112B50E738A0A8.6506@groups.io>
2022-09-07 3:05 ` [edk2-devel] [PATCH v3 2/8] FatPkg/FatPei: Remove extraneous debug message argument Michael Kubacki
[not found] ` <17127514CA861B0C.26635@groups.io>
2022-09-08 16:28 ` Michael Kubacki
2022-09-08 16:45 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902222206.1509-5-mikuback@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox