From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.4604.1662157372849151586 for ; Fri, 02 Sep 2022 15:22:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=FNlaUMxn; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id F14A42047797; Fri, 2 Sep 2022 15:22:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F14A42047797 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662157372; bh=HEH8pfzCx+eKsddbmsN/95lWIyMNHZgtZWlbJuE//28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FNlaUMxn8QofKyPdyBIpbcB1VKDJZN1X2sH285CB4BnMCYGcbjtpLGhTz00N302Hy 0gx0mKG+4r6lnd8KcbkVfADV751xbH3ZklY7azJetwhtq1FNXp0mYIpgpVzXCwjQ1u kdK13o0CmZNQvEQ+IjTOUSjv4qg2m0YNcfnRXve8= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Abner Chang , Nickle Wang Subject: [PATCH v3 4/8] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument Date: Fri, 2 Sep 2022 18:22:02 -0400 Message-Id: <20220902222206.1509-5-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220902222206.1509-1-mikuback@linux.microsoft.com> References: <20220902222206.1509-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki The debug macro argument in this change is removed since it does have a corresponding print specifier in the debug message string. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Michael Kubacki Reviewed-by: Abner Chang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 6 +++--- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 2 +- RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/Redfish= Pkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c index bf50c78c9280..586ecfadc715 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -264,12 +264,12 @@ Tcp6GetSubnetInfo ( =20 Status =3D Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NUL= L); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n")); + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __F= UNCTION__)); return Status; } =20 if (IpModedata.AddressCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n")); + DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __FUNCTION_= _)); } =20 if (Instance->SubnetAddrInfoIPv6 !=3D NULL) { @@ -278,7 +278,7 @@ Tcp6GetSubnetInfo ( =20 Instance->SubnetAddrInfoIPv6 =3D AllocateZeroPool (IpModedata.AddressC= ount * sizeof (EFI_IP6_ADDRESS_INFO)); if (Instance->SubnetAddrInfoIPv6 =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory fir IPv6 subnet = address information\n")); + DEBUG ((DEBUG_ERROR, "%a: Failed to allocate memory for IPv6 subnet = address information\n", __FUNCTION__)); return EFI_OUT_OF_RESOURCES; } =20 diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c= b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 8a05764ac605..623350bc261c 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -119,7 +119,7 @@ RedfishCreateSmbiosTable42 ( } else { NewProtocolRecords =3D ReallocatePool (CurrentProtocolsDataLength,= NewProtocolsDataLength, (VOID *)ProtocolRecords); if (NewProtocolRecords =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish ho= st interface protocol data.")); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for Redfish ho= st interface protocol data.", __FUNCTION__)); FreePool (ProtocolRecords); FreePool (ProtocolRecord); return EFI_OUT_OF_RESOURCES; diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/Redfis= hPkg/RedfishRestExDxe/RedfishRestExProtocol.c index f224104ad673..4b61fc01adc4 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -224,7 +224,7 @@ ReSendRequest:; DEBUG ((DEBUG_INFO, "HTTP_STATUS_200_OK\n")); =20 if (SendChunkProcess =3D=3D HttpIoSendChunkHeaderZeroContent) { - DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chu= nks.", ResponseData->Response.StatusCode)); + DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chu= nks.")); SendChunkProcess++; goto ReSendRequest; } --=20 2.28.0.windows.1