* [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file
@ 2022-09-05 14:29 Vijayenthiran Subramaniam
2022-09-06 12:36 ` Thomas Abraham
0 siblings, 1 reply; 3+ messages in thread
From: Vijayenthiran Subramaniam @ 2022-09-05 14:29 UTC (permalink / raw)
To: sami.mujawar, ardb+tianocore, thomas.abraham; +Cc: quic_llindhol, devel
The base address of NV storage are different on reference design
platforms after the introduction of the RD-N2 platform. So the comment
for the NV storage sizes for variables is corrected as it is now
inaccurate. The base address of NV storage is correctly listed in the
SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.
Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index b3627c7f0f01..2f5dadfaefc6 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
!endif
- # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
+ # NV Storage PCDs.
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file
2022-09-05 14:29 [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file Vijayenthiran Subramaniam
@ 2022-09-06 12:36 ` Thomas Abraham
2022-09-06 16:52 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Abraham @ 2022-09-06 12:36 UTC (permalink / raw)
To: Vijayenthiran Subramaniam, sami.mujawar, ardb+tianocore
Cc: quic_llindhol, devel
On 05/09/2022 15:29, Vijayenthiran Subramaniam wrote:
> The base address of NV storage are different on reference design
> platforms after the introduction of the RD-N2 platform. So the comment
> for the NV storage sizes for variables is corrected as it is now
> inaccurate. The base address of NV storage is correctly listed in the
> SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index b3627c7f0f01..2f5dadfaefc6 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
> gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
> !endif
>
> - # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
> + # NV Storage PCDs.
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file
2022-09-06 12:36 ` Thomas Abraham
@ 2022-09-06 16:52 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2022-09-06 16:52 UTC (permalink / raw)
To: Thomas Abraham
Cc: Vijayenthiran Subramaniam, sami.mujawar, ardb+tianocore,
quic_llindhol, devel
On Tue, 6 Sept 2022 at 14:36, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
>
>
> On 05/09/2022 15:29, Vijayenthiran Subramaniam wrote:
> > The base address of NV storage are different on reference design
> > platforms after the introduction of the RD-N2 platform. So the comment
> > for the NV storage sizes for variables is corrected as it is now
> > inaccurate. The base address of NV storage is correctly listed in the
> > SgiMemoryMap.dsc.inc and SgiMemoryMap2.dsc.inc files.
> >
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> > index b3627c7f0f01..2f5dadfaefc6 100644
> > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> > @@ -123,7 +123,7 @@ [PcdsFixedAtBuild.common]
> > gArmSgiTokenSpaceGuid.PcdOscCppcEnable|1
> > !endif
> >
> > - # NV Storage PCDs. Use base of 0x08000000 for NOR0, 0xC0000000 for NOR 1
> > + # NV Storage PCDs.
> > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x01400000
> > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize|0x01400000
> > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x01400000
>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
Pushed as bcad50b813ef..a81614e456b5
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-06 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-05 14:29 [edk2-platforms][PATCH] Platform/Sgi: Remove inaccurate comment in dsc file Vijayenthiran Subramaniam
2022-09-06 12:36 ` Thomas Abraham
2022-09-06 16:52 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox