From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry
Date: Tue, 6 Sep 2022 23:19:12 -0400 [thread overview]
Message-ID: <20220907031914.397-6-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com>
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048
The last [LibraryClasses] entry for FspWrapperPlatformMultiPhaseLib
points to the same entry as FspWrapperMultiPhaseProcessLib.
FspWrapperPlatformMultiPhaseHandler() is the only function
implemented in FspWrapperPlatformMultiPhaseLibNull.c and it is only
called (not implemented) in PeiFspWrapperMultiPhaseProcessLib.c,
so I'd assume:
- Producing library: FspWrapperPlatformMultiPhaseLib
- Consuming library: FspWrapperMultiPhaseProcessLib
But, the API descriptions do not provide any descriptive information:
FspWrapperPlatformMultiPhaseHandler():
```
/**
FSP Wrapper Platform MultiPhase Handler
@param[in] FspHobListPtr - Pointer to FSP HobList (valid
after FSP-M completed)
@param[in] ComponentIndex - FSP Component which executing
MultiPhase initialization.
@param[in] PhaseIndex - Indicates current execution phase
of FSP MultiPhase initialization.
@retval EFI_STATUS Always return EFI_SUCCESS
**/
```
In any case, this removes the redundant header file entry so the
Library Class Check CI test can pass on the package.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 4 ----
1 file changed, 4 deletions(-)
diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
index 95ada0f7a151..c3bbc5c45517 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
@@ -32,10 +32,6 @@ [LibraryClasses]
## @libraryclass Provide MultiPhase handling related functions.
FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProcessLib.h
- ## @libraryclass Provide MultiPhase platform actions related functions.
- FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProcessLib.h
-
-
[Guids]
#
# GUID defined in package
--
2.28.0.windows.1
next prev parent reply other threads:[~2022-09-07 3:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 3:19 [PATCH v1 0/7] Enable CI in Intel FSP Packages Michael Kubacki
2022-09-07 3:19 ` [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors Michael Kubacki
2022-09-07 3:36 ` [edk2-devel] " Chiu, Chasel
2022-09-07 3:19 ` [PATCH v1 2/7] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID Michael Kubacki
2022-09-07 3:33 ` Chiu, Chasel
2022-09-07 3:19 ` [PATCH v1 3/7] IntelFsp2Pkg: Add CI YAML file Michael Kubacki
2022-09-07 3:19 ` [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors Michael Kubacki
2022-09-07 3:34 ` Chiu, Chasel
2022-09-07 3:19 ` Michael Kubacki [this message]
2022-09-07 3:49 ` [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Chiu, Chasel
2022-09-07 4:34 ` Michael Kubacki
2022-09-07 4:47 ` Chiu, Chasel
2022-09-07 3:19 ` [PATCH v1 6/7] IntelFsp2WrapperPkg: Add CI YAML file Michael Kubacki
2022-09-07 3:19 ` [PATCH v1 7/7] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI Michael Kubacki
2022-09-09 1:35 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907031914.397-6-mikuback@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox