From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.3578.1662520788923529134 for ; Tue, 06 Sep 2022 20:19:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=OyYAXb3Z; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 057E620B929C; Tue, 6 Sep 2022 20:19:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 057E620B929C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662520788; bh=s+D9gj+fFn4BpGPLe+pk0ZM8J0hwDwd9RU94JoD8hKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OyYAXb3Ztp4EWLy4h9PmeGYBoc3g+wedltMhx2eXSGythrTqHpFSQE2UkzMQRKGzf JeGciPIKClDNwE4PhMDswzXSb0CfhBw8x1/zkC48PjVQyh4pdiekiCWNRUKJERlYhO lIHX/+GZA8nsjKrSJBvGJZlgrbcbhhJeX0AI6U4s= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Date: Tue, 6 Sep 2022 23:19:12 -0400 Message-Id: <20220907031914.397-6-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220907031914.397-1-mikuback@linux.microsoft.com> References: <20220907031914.397-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 The last [LibraryClasses] entry for FspWrapperPlatformMultiPhaseLib points to the same entry as FspWrapperMultiPhaseProcessLib. FspWrapperPlatformMultiPhaseHandler() is the only function implemented in FspWrapperPlatformMultiPhaseLibNull.c and it is only called (not implemented) in PeiFspWrapperMultiPhaseProcessLib.c, so I'd assume: - Producing library: FspWrapperPlatformMultiPhaseLib - Consuming library: FspWrapperMultiPhaseProcessLib But, the API descriptions do not provide any descriptive information: FspWrapperPlatformMultiPhaseHandler(): ``` /** FSP Wrapper Platform MultiPhase Handler @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FSP-M completed) @param[in] ComponentIndex - FSP Component which executing MultiPhase initialization. @param[in] PhaseIndex - Indicates current execution phase of FSP MultiPhase initialization. @retval EFI_STATUS Always return EFI_SUCCESS **/ ``` In any case, this removes the redundant header file entry so the Library Class Check CI test can pass on the package. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 4 ---- 1 file changed, 4 deletions(-) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2Wrapp= erPkg/IntelFsp2WrapperPkg.dec index 95ada0f7a151..c3bbc5c45517 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -32,10 +32,6 @@ [LibraryClasses] ## @libraryclass Provide MultiPhase handling related functions. FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhasePro= cessLib.h =20 - ## @libraryclass Provide MultiPhase platform actions related functio= ns. - FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhasePr= ocessLib.h - - [Guids] # # GUID defined in package --=20 2.28.0.windows.1