* [PATCH v1 0/2] SignedCapsulePkg: Enable CI
@ 2022-09-07 5:05 Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file Michael Kubacki
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Michael Kubacki @ 2022-09-07 5:05 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Jian J Wang
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
Adds SignedCapsulePkg to edk2 CI.
In the edk2 PR for this change, you can see that the package only
runs on GCC and CI passes with this configuration.
https://github.com/tianocore/edk2/pull/3304
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Michael Kubacki (2):
SignedCapsulePkg: Add package CI YAML file
.azurepipelines: Add SignedCapsulePkg to CI
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
.pytool/CISettings.py | 1 +
SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
3 files changed, 92 insertions(+), 1 deletion(-)
create mode 100644 SignedCapsulePkg/SignedCapsulePkg.ci.yaml
--
2.28.0.windows.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file
2022-09-07 5:05 [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael Kubacki
@ 2022-09-07 5:05 ` Michael Kubacki
2022-09-15 19:36 ` [edk2-devel] " Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI Michael Kubacki
2022-10-04 15:51 ` [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael D Kinney
2 siblings, 1 reply; 8+ messages in thread
From: Michael Kubacki @ 2022-09-07 5:05 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
Adds the package as a supported package to .pytool/CISettings.py
and adds a CI YAML for the package so it can be run in CI.
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.pytool/CISettings.py | 1 +
SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
2 files changed, 91 insertions(+)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index cf9e0d77b19b..306e27893e58 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
"UefiCpuPkg",
"FmpDevicePkg",
"ShellPkg",
+ "SignedCapsulePkg",
"StandaloneMmPkg",
"FatPkg",
"CryptoPkg",
diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
new file mode 100644
index 000000000000..5f48613bd79f
--- /dev/null
+++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
@@ -0,0 +1,90 @@
+## @file
+# Core CI configuration for SignedCapsulePkg
+#
+# Copyright (c) Microsoft Corporation
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ ## options defined .pytool/Plugin/LicenseCheck
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/CompilerPlugin
+ "CompilerPlugin": {
+ "DscPath": "SignedCapsulePkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+ "HostUnitTestCompilerPlugin": {
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/CharEncodingCheck
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/DependencyCheck
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "MdeModulePkg/MdeModulePkg.dec",
+ "MdePkg/MdePkg.dec",
+ "SecurityPkg/SecurityPkg.dec",
+ "SignedCapsulePkg/SignedCapsulePkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[
+ "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+ ],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[],
+ "IgnoreInf": []
+ },
+
+ ## options defined .pytool/Plugin/DscCompleteCheck
+ "DscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "SignedCapsulePkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+ "HostUnitTestDscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/GuidCheck
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": [],
+ },
+
+ ## options defined .pytool/Plugin/LibraryClassCheck
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined .pytool/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": True, # Failures need to be reviewed and resolved in the future
+ "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
+ "ExtendWords": [], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
+ "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+ }
+}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI
2022-09-07 5:05 [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file Michael Kubacki
@ 2022-09-07 5:05 ` Michael Kubacki
2022-09-09 1:36 ` Michael D Kinney
2022-10-04 15:51 ` [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael D Kinney
2 siblings, 1 reply; 8+ messages in thread
From: Michael Kubacki @ 2022-09-07 5:05 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Jian J Wang
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
Adds SignedCapsulePkg to the "OTHER" CI matrix job so it is built
in edk2 CI.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 0e4ad019bf03..f37cc826b51e 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -37,7 +37,7 @@ jobs:
Build.Pkgs: 'NetworkPkg,RedfishPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_OTHER:
- Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
+ Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg,SignedCapsulePkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_FMP_FAT_TEST:
Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI
2022-09-07 5:05 ` [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI Michael Kubacki
@ 2022-09-09 1:36 ` Michael D Kinney
0 siblings, 0 replies; 8+ messages in thread
From: Michael D Kinney @ 2022-09-09 1:36 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io,
Kinney, Michael D
Cc: Sean Brogan, Barkelew, Bret, Gao, Liming, Wang, Jian J
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, September 6, 2022 10:06 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret <bret.barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
>
> Adds SignedCapsulePkg to the "OTHER" CI matrix job so it is built
> in edk2 CI.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 0e4ad019bf03..f37cc826b51e 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -37,7 +37,7 @@ jobs:
> Build.Pkgs: 'NetworkPkg,RedfishPkg'
> Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
> TARGET_OTHER:
> - Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
> + Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg,SignedCapsulePkg'
> Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
> TARGET_FMP_FAT_TEST:
> Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file
2022-09-07 5:05 ` [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file Michael Kubacki
@ 2022-09-15 19:36 ` Michael Kubacki
2022-09-23 1:06 ` Michael Kubacki
0 siblings, 1 reply; 8+ messages in thread
From: Michael Kubacki @ 2022-09-15 19:36 UTC (permalink / raw)
To: devel, Jian J Wang; +Cc: Michael D Kinney
Hi Jian,
Can you please provide a review for this patch?
Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series
will be ready once this patch is reviewed.
Thanks,
Michael
On 9/7/2022 1:05 AM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
>
> Adds the package as a supported package to .pytool/CISettings.py
> and adds a CI YAML for the package so it can be run in CI.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> .pytool/CISettings.py | 1 +
> SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
> 2 files changed, 91 insertions(+)
>
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
> index cf9e0d77b19b..306e27893e58 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
> "UefiCpuPkg",
> "FmpDevicePkg",
> "ShellPkg",
> + "SignedCapsulePkg",
> "StandaloneMmPkg",
> "FatPkg",
> "CryptoPkg",
> diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
> new file mode 100644
> index 000000000000..5f48613bd79f
> --- /dev/null
> +++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
> @@ -0,0 +1,90 @@
> +## @file
> +# Core CI configuration for SignedCapsulePkg
> +#
> +# Copyright (c) Microsoft Corporation
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> + ## options defined .pytool/Plugin/LicenseCheck
> + "LicenseCheck": {
> + "IgnoreFiles": []
> + },
> +
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": []
> + },
> +
> + ## options defined .pytool/Plugin/CompilerPlugin
> + "CompilerPlugin": {
> + "DscPath": "SignedCapsulePkg.dsc"
> + },
> +
> + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
> + "HostUnitTestCompilerPlugin": {
> + "DscPath": "" # Don't support this test
> + },
> +
> + ## options defined .pytool/Plugin/CharEncodingCheck
> + "CharEncodingCheck": {
> + "IgnoreFiles": []
> + },
> +
> + ## options defined .pytool/Plugin/DependencyCheck
> + "DependencyCheck": {
> + "AcceptableDependencies": [
> + "MdeModulePkg/MdeModulePkg.dec",
> + "MdePkg/MdePkg.dec",
> + "SecurityPkg/SecurityPkg.dec",
> + "SignedCapsulePkg/SignedCapsulePkg.dec"
> + ],
> + # For host based unit tests
> + "AcceptableDependencies-HOST_APPLICATION":[
> + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
> + ],
> + # For UEFI shell based apps
> + "AcceptableDependencies-UEFI_APPLICATION":[],
> + "IgnoreInf": []
> + },
> +
> + ## options defined .pytool/Plugin/DscCompleteCheck
> + "DscCompleteCheck": {
> + "IgnoreInf": [""],
> + "DscPath": "SignedCapsulePkg.dsc"
> + },
> +
> + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
> + "HostUnitTestDscCompleteCheck": {
> + "IgnoreInf": [""],
> + "DscPath": "" # Don't support this test
> + },
> +
> + ## options defined .pytool/Plugin/GuidCheck
> + "GuidCheck": {
> + "IgnoreGuidName": [],
> + "IgnoreGuidValue": [],
> + "IgnoreFoldersAndFiles": [],
> + "IgnoreDuplicates": [],
> + },
> +
> + ## options defined .pytool/Plugin/LibraryClassCheck
> + "LibraryClassCheck": {
> + "IgnoreHeaderFile": []
> + },
> +
> + ## options defined .pytool/Plugin/SpellCheck
> + "SpellCheck": {
> + "AuditOnly": True, # Failures need to be reviewed and resolved in the future
> + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
> + "ExtendWords": [], # words to extend to the dictionary for this package
> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
> + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> + }
> +}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file
2022-09-15 19:36 ` [edk2-devel] " Michael Kubacki
@ 2022-09-23 1:06 ` Michael Kubacki
2022-10-03 14:45 ` Michael Kubacki
0 siblings, 1 reply; 8+ messages in thread
From: Michael Kubacki @ 2022-09-23 1:06 UTC (permalink / raw)
To: devel, Jian J Wang; +Cc: Michael D Kinney
Review reminder
On 9/15/2022 3:36 PM, Michael Kubacki wrote:
> Hi Jian,
>
> Can you please provide a review for this patch?
>
> Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series
> will be ready once this patch is reviewed.
>
> Thanks,
> Michael
>
> On 9/7/2022 1:05 AM, Michael Kubacki wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
>>
>> Adds the package as a supported package to .pytool/CISettings.py
>> and adds a CI YAML for the package so it can be run in CI.
>>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>> .pytool/CISettings.py | 1 +
>> SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
>> 2 files changed, 91 insertions(+)
>>
>> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
>> index cf9e0d77b19b..306e27893e58 100644
>> --- a/.pytool/CISettings.py
>> +++ b/.pytool/CISettings.py
>> @@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager,
>> UpdateSettingsManager, SetupSettingsManag
>> "UefiCpuPkg",
>> "FmpDevicePkg",
>> "ShellPkg",
>> + "SignedCapsulePkg",
>> "StandaloneMmPkg",
>> "FatPkg",
>> "CryptoPkg",
>> diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>> b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>> new file mode 100644
>> index 000000000000..5f48613bd79f
>> --- /dev/null
>> +++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>> @@ -0,0 +1,90 @@
>> +## @file
>> +# Core CI configuration for SignedCapsulePkg
>> +#
>> +# Copyright (c) Microsoft Corporation
>> +#
>> +# SPDX-License-Identifier: BSD-2-Clause-Patent
>> +##
>> +{
>> + ## options defined .pytool/Plugin/LicenseCheck
>> + "LicenseCheck": {
>> + "IgnoreFiles": []
>> + },
>> +
>> + "EccCheck": {
>> + ## Exception sample looks like below:
>> + ## "ExceptionList": [
>> + ## "<ErrorID>", "<KeyWord>"
>> + ## ]
>> + "ExceptionList": [
>> + ],
>> + ## Both file path and directory path are accepted.
>> + "IgnoreFiles": []
>> + },
>> +
>> + ## options defined .pytool/Plugin/CompilerPlugin
>> + "CompilerPlugin": {
>> + "DscPath": "SignedCapsulePkg.dsc"
>> + },
>> +
>> + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
>> + "HostUnitTestCompilerPlugin": {
>> + "DscPath": "" # Don't support this test
>> + },
>> +
>> + ## options defined .pytool/Plugin/CharEncodingCheck
>> + "CharEncodingCheck": {
>> + "IgnoreFiles": []
>> + },
>> +
>> + ## options defined .pytool/Plugin/DependencyCheck
>> + "DependencyCheck": {
>> + "AcceptableDependencies": [
>> + "MdeModulePkg/MdeModulePkg.dec",
>> + "MdePkg/MdePkg.dec",
>> + "SecurityPkg/SecurityPkg.dec",
>> + "SignedCapsulePkg/SignedCapsulePkg.dec"
>> + ],
>> + # For host based unit tests
>> + "AcceptableDependencies-HOST_APPLICATION":[
>> + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
>> + ],
>> + # For UEFI shell based apps
>> + "AcceptableDependencies-UEFI_APPLICATION":[],
>> + "IgnoreInf": []
>> + },
>> +
>> + ## options defined .pytool/Plugin/DscCompleteCheck
>> + "DscCompleteCheck": {
>> + "IgnoreInf": [""],
>> + "DscPath": "SignedCapsulePkg.dsc"
>> + },
>> +
>> + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
>> + "HostUnitTestDscCompleteCheck": {
>> + "IgnoreInf": [""],
>> + "DscPath": "" # Don't support this test
>> + },
>> +
>> + ## options defined .pytool/Plugin/GuidCheck
>> + "GuidCheck": {
>> + "IgnoreGuidName": [],
>> + "IgnoreGuidValue": [],
>> + "IgnoreFoldersAndFiles": [],
>> + "IgnoreDuplicates": [],
>> + },
>> +
>> + ## options defined .pytool/Plugin/LibraryClassCheck
>> + "LibraryClassCheck": {
>> + "IgnoreHeaderFile": []
>> + },
>> +
>> + ## options defined .pytool/Plugin/SpellCheck
>> + "SpellCheck": {
>> + "AuditOnly": True, # Failures need to be reviewed
>> and resolved in the future
>> + "IgnoreFiles": [], # use gitignore syntax to ignore
>> errors in matching files
>> + "ExtendWords": [], # words to extend to the
>> dictionary for this package
>> + "IgnoreStandardPaths": [], # Standard Plugin defined paths
>> that should be ignore
>> + "AdditionalIncludePaths": [] # Additional paths to spell
>> check (wildcards supported)
>> + }
>> +}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file
2022-09-23 1:06 ` Michael Kubacki
@ 2022-10-03 14:45 ` Michael Kubacki
0 siblings, 0 replies; 8+ messages in thread
From: Michael Kubacki @ 2022-10-03 14:45 UTC (permalink / raw)
To: devel, Jian J Wang; +Cc: Michael D Kinney
Another reminder.
On 9/22/2022 9:06 PM, Michael Kubacki wrote:
> Review reminder
>
> On 9/15/2022 3:36 PM, Michael Kubacki wrote:
>> Hi Jian,
>>
>> Can you please provide a review for this patch?
>>
>> Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series
>> will be ready once this patch is reviewed.
>>
>> Thanks,
>> Michael
>>
>> On 9/7/2022 1:05 AM, Michael Kubacki wrote:
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
>>>
>>> Adds the package as a supported package to .pytool/CISettings.py
>>> and adds a CI YAML for the package so it can be run in CI.
>>>
>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>> .pytool/CISettings.py | 1 +
>>> SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
>>> 2 files changed, 91 insertions(+)
>>>
>>> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
>>> index cf9e0d77b19b..306e27893e58 100644
>>> --- a/.pytool/CISettings.py
>>> +++ b/.pytool/CISettings.py
>>> @@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager,
>>> UpdateSettingsManager, SetupSettingsManag
>>> "UefiCpuPkg",
>>> "FmpDevicePkg",
>>> "ShellPkg",
>>> + "SignedCapsulePkg",
>>> "StandaloneMmPkg",
>>> "FatPkg",
>>> "CryptoPkg",
>>> diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>>> b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>>> new file mode 100644
>>> index 000000000000..5f48613bd79f
>>> --- /dev/null
>>> +++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>>> @@ -0,0 +1,90 @@
>>> +## @file
>>> +# Core CI configuration for SignedCapsulePkg
>>> +#
>>> +# Copyright (c) Microsoft Corporation
>>> +#
>>> +# SPDX-License-Identifier: BSD-2-Clause-Patent
>>> +##
>>> +{
>>> + ## options defined .pytool/Plugin/LicenseCheck
>>> + "LicenseCheck": {
>>> + "IgnoreFiles": []
>>> + },
>>> +
>>> + "EccCheck": {
>>> + ## Exception sample looks like below:
>>> + ## "ExceptionList": [
>>> + ## "<ErrorID>", "<KeyWord>"
>>> + ## ]
>>> + "ExceptionList": [
>>> + ],
>>> + ## Both file path and directory path are accepted.
>>> + "IgnoreFiles": []
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/CompilerPlugin
>>> + "CompilerPlugin": {
>>> + "DscPath": "SignedCapsulePkg.dsc"
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
>>> + "HostUnitTestCompilerPlugin": {
>>> + "DscPath": "" # Don't support this test
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/CharEncodingCheck
>>> + "CharEncodingCheck": {
>>> + "IgnoreFiles": []
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/DependencyCheck
>>> + "DependencyCheck": {
>>> + "AcceptableDependencies": [
>>> + "MdeModulePkg/MdeModulePkg.dec",
>>> + "MdePkg/MdePkg.dec",
>>> + "SecurityPkg/SecurityPkg.dec",
>>> + "SignedCapsulePkg/SignedCapsulePkg.dec"
>>> + ],
>>> + # For host based unit tests
>>> + "AcceptableDependencies-HOST_APPLICATION":[
>>> + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
>>> + ],
>>> + # For UEFI shell based apps
>>> + "AcceptableDependencies-UEFI_APPLICATION":[],
>>> + "IgnoreInf": []
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/DscCompleteCheck
>>> + "DscCompleteCheck": {
>>> + "IgnoreInf": [""],
>>> + "DscPath": "SignedCapsulePkg.dsc"
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
>>> + "HostUnitTestDscCompleteCheck": {
>>> + "IgnoreInf": [""],
>>> + "DscPath": "" # Don't support this test
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/GuidCheck
>>> + "GuidCheck": {
>>> + "IgnoreGuidName": [],
>>> + "IgnoreGuidValue": [],
>>> + "IgnoreFoldersAndFiles": [],
>>> + "IgnoreDuplicates": [],
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/LibraryClassCheck
>>> + "LibraryClassCheck": {
>>> + "IgnoreHeaderFile": []
>>> + },
>>> +
>>> + ## options defined .pytool/Plugin/SpellCheck
>>> + "SpellCheck": {
>>> + "AuditOnly": True, # Failures need to be reviewed
>>> and resolved in the future
>>> + "IgnoreFiles": [], # use gitignore syntax to
>>> ignore errors in matching files
>>> + "ExtendWords": [], # words to extend to the
>>> dictionary for this package
>>> + "IgnoreStandardPaths": [], # Standard Plugin defined paths
>>> that should be ignore
>>> + "AdditionalIncludePaths": [] # Additional paths to spell
>>> check (wildcards supported)
>>> + }
>>> +}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] SignedCapsulePkg: Enable CI
2022-09-07 5:05 [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI Michael Kubacki
@ 2022-10-04 15:51 ` Michael D Kinney
2 siblings, 0 replies; 8+ messages in thread
From: Michael D Kinney @ 2022-10-04 15:51 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io,
Kinney, Michael D
Cc: Sean Brogan, Barkelew, Bret, Gao, Liming, Wang, Jian J
Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, September 6, 2022 10:05 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Barkelew, Bret <bret.barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH v1 0/2] SignedCapsulePkg: Enable CI
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4050
>
> Adds SignedCapsulePkg to edk2 CI.
>
> In the edk2 PR for this change, you can see that the package only
> runs on GCC and CI passes with this configuration.
>
> https://github.com/tianocore/edk2/pull/3304
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (2):
> SignedCapsulePkg: Add package CI YAML file
> .azurepipelines: Add SignedCapsulePkg to CI
>
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> .pytool/CISettings.py | 1 +
> SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 ++++++++++++++++++++
> 3 files changed, 92 insertions(+), 1 deletion(-)
> create mode 100644 SignedCapsulePkg/SignedCapsulePkg.ci.yaml
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-04 15:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-07 5:05 [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file Michael Kubacki
2022-09-15 19:36 ` [edk2-devel] " Michael Kubacki
2022-09-23 1:06 ` Michael Kubacki
2022-10-03 14:45 ` Michael Kubacki
2022-09-07 5:05 ` [PATCH v1 2/2] .azurepipelines: Add SignedCapsulePkg to CI Michael Kubacki
2022-09-09 1:36 ` Michael D Kinney
2022-10-04 15:51 ` [PATCH v1 0/2] SignedCapsulePkg: Enable CI Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox