From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: Oliver Steffen <osteffen@redhat.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v3 1/1] OvmfPkg/QemuVideoDxe: fix bochs mode init
Date: Wed, 7 Sep 2022 11:54:19 +0200 [thread overview]
Message-ID: <20220907095419.4emdo6e7ys26iz4y@sirius.home.kraxel.org> (raw)
In-Reply-To: <20220907091504.3152616-1-kraxel@redhat.com>
On Wed, Sep 07, 2022 at 11:15:04AM +0200, Gerd Hoffmann wrote:
> Add VgaInb() helper function to read vga registers. With that in place
> fix the unblanking. We need to put the ATT_ADDRESS_REGISTER flip flop
> into a known state, which is done by reading the
> INPUT_STATUS_1_REGISTER. Reading the INPUT_STATUS_1_REGISTER only works
> when the device is in color mode, so make sure that bit (0x01) is set in
> MISC_OUTPUT_REGISTER.
>
> Currently the mode setting works more by luck because
> ATT_ADDRESS_REGISTER flip flop happens to be in the state we need.
The 'patch is small and simple enough that I can skip CI' plan didn't
went so well for v1+2, so: https://github.com/tianocore/edk2/pull/3311
take care,
Gerd
prev parent reply other threads:[~2022-09-07 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 9:15 [PATCH v3 1/1] OvmfPkg/QemuVideoDxe: fix bochs mode init Gerd Hoffmann
2022-09-07 9:44 ` Ard Biesheuvel
2022-09-07 9:54 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907095419.4emdo6e7ys26iz4y@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox