From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.5796.1662544463139113892 for ; Wed, 07 Sep 2022 02:54:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hq6tSN2b; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662544462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=haW8x3Sg26Fx3lumhozZkp8jJPmdUqlxx3vdByffa3k=; b=hq6tSN2bNeiqdNmxPqL2d1z1l0KJMMPcGyDMDMRKdu0yNHQUzwLG3080BTZijXB0q7bUFF FBd5Ig/sIcWR72EeB8dbfsaD3Pzz909E4cTOHCIzXOJCPMyBS+bkc8USy3k1UPJF4uGyGb KcjAfTX7t4zdKlD6654LhUpWYg6X+Do= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-52lbeIEKMhiS36PLlCrvNQ-1; Wed, 07 Sep 2022 05:54:21 -0400 X-MC-Unique: 52lbeIEKMhiS36PLlCrvNQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E727C1C0CE62; Wed, 7 Sep 2022 09:54:20 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.195.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7BF2492C3B; Wed, 7 Sep 2022 09:54:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 479CF180039B; Wed, 7 Sep 2022 11:54:19 +0200 (CEST) Date: Wed, 7 Sep 2022 11:54:19 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , Pawel Polawski , Jiewen Yao , Ard Biesheuvel , Jordan Justen Subject: Re: [PATCH v3 1/1] OvmfPkg/QemuVideoDxe: fix bochs mode init Message-ID: <20220907095419.4emdo6e7ys26iz4y@sirius.home.kraxel.org> References: <20220907091504.3152616-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220907091504.3152616-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 07, 2022 at 11:15:04AM +0200, Gerd Hoffmann wrote: > Add VgaInb() helper function to read vga registers. With that in place > fix the unblanking. We need to put the ATT_ADDRESS_REGISTER flip flop > into a known state, which is done by reading the > INPUT_STATUS_1_REGISTER. Reading the INPUT_STATUS_1_REGISTER only works > when the device is in color mode, so make sure that bit (0x01) is set in > MISC_OUTPUT_REGISTER. > > Currently the mode setting works more by luck because > ATT_ADDRESS_REGISTER flip flop happens to be in the state we need. The 'patch is small and simple enough that I can skip CI' plan didn't went so well for v1+2, so: https://github.com/tianocore/edk2/pull/3311 take care, Gerd