public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1] MinPlatformPkg: Remove _ADR from MinDsdt.asl
@ 2022-09-12  5:12 aryeh.chen
  0 siblings, 0 replies; only message in thread
From: aryeh.chen @ 2022-09-12  5:12 UTC (permalink / raw)
  To: devel
  Cc: Aryeh Chen, Chasel Chiu, Nate DeSimone, Isaac Oram, Sinha, Ankit,
	Liming Gao, Eric Dong

From: Aryeh Chen <aryeh.chen@intel.com>

According to ASL Coding Guidelines - Device Identifiers
"A Device should contain either an _ADR or a _HID object, never both."
, so remove _ADR due to _HID exist.

Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Sinha, Ankit <ankit.sinha@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
index 0d94472450..4efb8709ac 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
@@ -27,7 +27,6 @@ DefinitionBlock (
       Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy
       Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID
       Name(_SEG, 0)
-      Name(_ADR, 0x00000000)
       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus number for Peer PCI busses. Name can be overriden with control method placed directly under Device scope
       Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root PCI Bus
       Name(_UID, 0x0000)  // Unique Bus ID, optional
-- 
2.26.2.windows.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-12  5:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-12  5:12 [PATCH v1] MinPlatformPkg: Remove _ADR from MinDsdt.asl aryeh.chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox