From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.4217.1662959872341173582 for ; Sun, 11 Sep 2022 22:17:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ea8zfMIZ; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: aryeh.chen@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662959872; x=1694495872; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/y+R9eeDCWXAbdWv6IEaFqDUaPj7axR77ONV6abtYY8=; b=ea8zfMIZSU9bNPwvd5Sk3nx3tXqGvSzzpluyiUewfRducCJpqctIhOW9 Nzx+BGCwKFvZYkmul7X+13eCD3gZmBGmPk6WVf1zhOkLzCBl6LKt2DqJq GKOwWe7b1mopwqqcT8ojlyfhH968nyrH1O5k459qt2WM1wuEHtMdzIRTD 5gaf5D5yk5dyjyYMvhGSe8rIIpbnBdaY32Y0nx1S4eMTcqUUsJEn9XZRA poJhQj6RNvUYCzI1a5DoJM9koEoakgd+0uYFfRDelG6h0ZHG7oXyvnvbk vwPd8VYv/XUMY3yyZZqzMiQtyEcxo1s1qyNe70ogAWAHM1UIO4yPLg2dI w==; X-IronPort-AV: E=McAfee;i="6500,9779,10467"; a="384083071" X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="384083071" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2022 22:17:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="705038186" Received: from aryehche-desk1.gar.corp.intel.com ([10.5.215.0]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2022 22:17:50 -0700 From: aryeh.chen@intel.com To: devel@edk2.groups.io Cc: Aryeh Chen , Chasel Chiu , Nate DeSimone , Isaac Oram , Ankit Sinha , Liming Gao , Eric Dong Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Date: Mon, 12 Sep 2022 13:17:45 +0800 Message-Id: <20220912051745.1539-1-aryeh.chen@intel.com> X-Mailer: git-send-email 2.26.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Aryeh Chen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 According to ASL Coding Guidelines - Device Identifiers "A Device should contain either an _ADR or a _HID object, never both." , so remove _ADR due to _HID exist. Signed-off-by: Aryeh Chen Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Ankit Sinha Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platf= orm/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl index 0d94472450..4efb8709ac 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl @@ -27,7 +27,6 @@ DefinitionBlock ( Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 h= ost hierarchy=0D Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't u= nderstand the new HID=0D Name(_SEG, 0)=0D - Name(_ADR, 0x00000000)=0D Method(^BN00, 0){ return(0x0000) } // Returns default Bus number fo= r Peer PCI busses. Name can be overriden with control method placed directl= y under Device scope=0D Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Ro= ot PCI Bus=0D Name(_UID, 0x0000) // Unique Bus ID, optional=0D --=20 2.26.2.windows.1