From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web12.5187.1662971563025653790 for ; Mon, 12 Sep 2022 01:32:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cQ3w9bc+; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: imammedo@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662971562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bz8XPRXkDRVzkrU6+Sbol1GGAKcHQL4Yp64QHKkzyTc=; b=cQ3w9bc+cCfRF4MYmN88y8uv0O4EDOaUmIvMZ3qJrA5Dk26GYi4/n+mX05eQs57JprAfjY SnKVRwRG+gIkIKGjl8rlL2oerATr9Hs8ABatpofnLTLx+VVR0v0RVXD8/9zeRRgMBu+fEa HRsnw2TdA4dwd8VlINoP1xwRsEobLf0= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-581-EW3Wnu3TO--J90jIMVm9wg-1; Mon, 12 Sep 2022 04:32:40 -0400 X-MC-Unique: EW3Wnu3TO--J90jIMVm9wg-1 Received: by mail-ed1-f69.google.com with SMTP id f18-20020a056402355200b0045115517911so5358277edd.14 for ; Mon, 12 Sep 2022 01:32:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=Bz8XPRXkDRVzkrU6+Sbol1GGAKcHQL4Yp64QHKkzyTc=; b=Pqd7DEsyIt/D3bzicvuOs9Db6CVXl4uS2nyPnEF5EUN9h410ik5BInrOFm86eoo9iM 7jSjlngSmckhHTmarDJwN9QlVVh+YKxbYkt7ERRS1u6ACfm8Wj/UZWKl7pP9ZC7Nmi2T dH2BJy/8ZOpxD/ss/GJhl4icP34SkD3F3g1Bv4MtV1WGACXMu87RY3OY1dNAxn6Z1eMY e64jS3z+gDiy5UMtoi2lr1sz0nUz8Z+QiCS0Q56GrlsQDe2eTqONsswErzQT9rGNYXg1 Gap2Fp9w/Hw+DPMJdlMLFBl1GygN9BkNRocM4v/zIZuJlmiY2d438f5MXHlX6ck2jn27 F+eQ== X-Gm-Message-State: ACgBeo0RdkEA8Q1TJ9CFPugzQjV/dhgYL8rCcqrHykSAKbPVV+H7gGE6 9RFsbDEr/sH+WPdVjgeboNCGeCC91d7wYOvqQ5I874MC1pwvdFLLJ/Ahq5f94b2zzwekEXOtInC +/ljCchVelxtbrA== X-Received: by 2002:a05:6402:110d:b0:451:9fc5:fe7f with SMTP id u13-20020a056402110d00b004519fc5fe7fmr4610027edv.200.1662971559065; Mon, 12 Sep 2022 01:32:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7WsbUY45S11w1QVxYXbYqTFjJobSXcmXNjwYyWuMXSScWE0ccFUM65JyWWc2rgkRPUCGaZEA== X-Received: by 2002:a05:6402:110d:b0:451:9fc5:fe7f with SMTP id u13-20020a056402110d00b004519fc5fe7fmr4610014edv.200.1662971558830; Mon, 12 Sep 2022 01:32:38 -0700 (PDT) Return-Path: Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id q10-20020a50c34a000000b0044838efb8f8sm5293367edb.25.2022.09.12.01.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 01:32:37 -0700 (PDT) Date: Mon, 12 Sep 2022 10:32:36 +0200 From: "Igor Mammedov" To: aryeh.chen@intel.com Cc: devel@edk2.groups.io, Chasel Chiu , Nate DeSimone , Isaac Oram , Ankit Sinha , Liming Gao , Eric Dong Subject: Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Message-ID: <20220912103236.7eff2e35@redhat.com> In-Reply-To: <20220912051745.1539-1-aryeh.chen@intel.com> References: <20220912051745.1539-1-aryeh.chen@intel.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 12 Sep 2022 13:17:45 +0800 aryeh.chen@intel.com wrote: > From: Aryeh Chen > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057 > > According to ASL Coding Guidelines - Device Identifiers > "A Device should contain either an _ADR or a _HID object, never both." > , so remove _ADR due to _HID exist. I'm curious where exactly in ACPI spec it's said... > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Ankit Sinha > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 0d94472450..4efb8709ac 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -27,7 +27,6 @@ DefinitionBlock ( > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 host hierarchy > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't understand the new HID > Name(_SEG, 0) > - Name(_ADR, 0x00000000) Spec also says v6.3 6.1.1 _ADR (Address) An _ADR object must be used when specifying the address of any device on a bus that has a standard enumeration algorithm > Method(^BN00, 0){ return(0x0000) } // Returns default Bus number for Peer PCI busses. Name can be overriden with control method placed directly under Device scope > Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root PCI Bus > Name(_UID, 0x0000) // Unique Bus ID, optional