From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.109]) by mx.groups.io with SMTP id smtpd.web11.1630.1663050179347644712 for ; Mon, 12 Sep 2022 23:22:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=MWlv4JdE; spf=pass (domain: os.amperecomputing.com, ip: 40.107.220.109, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4wZKeYFp6XXpJYZKxJe3mppPIg7AfVXDU/BmN/Y+PfjnfbeMMCTEUlao2RVyZA1BQw1pAq/cVlL/FaRHF04BOvWHzsa1ac4PCBTRMW84UsRFoqn24/vWZFtJaIB/FwFgWQo7otYpwsm05tO4FXPhoTpf0SnXBfU7T1mwvuuL/E3R+/qzLZ/G7sVser2i6B7c2hUxYE/djPFDOH7qXH2+oSyzg+QGUwbIzB7ejiTJ1nU+D5Btq4fxjsLa3v+d2SGLbARcyVZwQ3akFVdYjTB6bm3hB9Jbs7WljPWq9AEDqIiOktRK4FMVh2dVm2XNliPtwGrhnPknyj8ciM/aqXazQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQu7gfal5joMfx7qqLSO50gMjHRIKl1Q66BGCZz4iP0=; b=Dv0RaXJEipWWyk8D9pIxKbeHPbdMe6eiYvTemnaXOtwnQCPTI8BxVWMefznM0B5q4DdmvtPaXKyAkjF1VVJJpKvO6Wzsdh/+oKGURcNdN8DMcNtu5yxiWhdSdzUs5iC54IeNyRL0eKmLegvT+iSM0/YvCtdq8YY81NRFvnKCjrxdwnNBxrDoYhpPbV9ZpAK6TBmLhiY6aohFM1uoMDI38+j+a9wTUqeFS3L3d3lp2KgIhWr6Kfoc/HpTWiKVK1HlhUvr3wFzqCXuKNFqYpivN65RXhxArTAvrMkYQMG/RULpjFoe9AzStEiByQUCl1tLO0CHXZghps6k+9isdN8SCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQu7gfal5joMfx7qqLSO50gMjHRIKl1Q66BGCZz4iP0=; b=MWlv4JdEH9NQ8BXPKfqao2uzvGCzFMKI8fdw+3/y3RpDbYiar/cKKPubr4gTrqnbRVwd6FFk/mQw+rd5liVEPCVQD5/eVe8JlQK+vls88EaQrWq1ZHD9GB/ASJHgpfMRCpLaAVUruO1NXFFuWA23am991cWjkw75tfwuzktWPEA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM6PR01MB3644.prod.exchangelabs.com (2603:10b6:5:92::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 06:22:56 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc6b:4f56:8f32:dfa5]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc6b:4f56:8f32:dfa5%4]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 06:22:56 +0000 From: "Nhi Pham" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran , Ard Biesheuvel Subject: [PATCH v3 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 Date: Tue, 13 Sep 2022 13:19:46 +0700 Message-Id: <20220913061947.735951-6-nhi@os.amperecomputing.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220913061947.735951-1-nhi@os.amperecomputing.com> References: <20220913061947.735951-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SG2PR06CA0194.apcprd06.prod.outlook.com (2603:1096:4:1::26) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|DM6PR01MB3644:EE_ X-MS-Office365-Filtering-Correlation-Id: 7243d615-f601-4ebd-e1ad-08da95506572 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UDtPaFulQTlWrmHSczc/EnGJiS6aqNgbyadd3wz9CmvEl8cCNGW2A/PjAZylWiPt0f4ggOpQaOyrz6Lr7KE9lIXDc2QTd2XXudM1mqtHDLCp6LyCwwQgRuxeVrRzaCSSoHjxsAdZtWoj/ZQqe4svNitbjOl4Vez2ojXQpzs+Pnci1d837I+I4juqXkN4EWrvdR3VH4bdn8/luznb6u4IB9mhkEMJsO90K3zc8UaDvhNw8+B87p9R3znQCl3bUQJDK0yshJfQLVZZxrrofKcCqRsIbpJFTb6vM2D6z9xmp0luECna+/0iYNZv3TnVzqd0LCo3ncY+SeVJZU+JywfmV9OvAmMJMvjF27Hxkh7nLAlEvmK3QQBkeG3ob8l9qnNO5Uhb0p9zAmkcM81obhtG+eJKLxKfSi5+7wLPx3/8alAcoh/rRhJOHCL9C74KSZMAE/Up5coJgCo6i1sVILLKlmTAaAyTWwV9NzGeCjDS1oMt3CK5rvNSnXFNp/ATRv4NGdo5ZYIHegLmMKoWbYWF2RXWevgxjtFz0w0FsBGGq+POUJZqfKHoEMA4Jdp5FxEG3OoRm75TkhcmTNpj+C2H0pEXF3+1DlA8pijnX6URG6f+tKEsJHDTWA6BqkXW2kIXCXFj4YQ0pMgRX459IJjtwuLS34+EkJcV2eOyo3jgjr/6lyXPJZ4mCymSDIpZ793CO3tCqeezIIdspouydzaF4qpu2JmRWt4QPv5/fliKLa/RdU1kygFhiMnQSVwHexJ+jsflJMaqJbyWzyZbycQHvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39850400004)(136003)(366004)(376002)(346002)(451199015)(19627235002)(66556008)(6666004)(8676002)(15650500001)(316002)(66946007)(478600001)(4326008)(66476007)(83380400001)(2616005)(6512007)(86362001)(45954011)(41300700001)(6486002)(26005)(54906003)(2906002)(6506007)(186003)(5660300002)(1076003)(38100700002)(8936002)(38350700002)(52116002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BbWzou8zd9G3OR3vHmNlu0w++jHD44P8HWi1LCmnXHA73ciwtYieIjYOKRIr?= =?us-ascii?Q?5RUAlJbBUHCX4fJ1+jb1UZw6Z0BGYgj2CS+8bMeoHMTrjLYcZdTZrDBVPg2u?= =?us-ascii?Q?0u6lpIeuh317R/GpxS5/+g34x8hVjGCXwNRcI725uIOKR32c52BbcQLagz/n?= =?us-ascii?Q?NEymiiEvZlhb9fMUJe8boc5bXBN3fFEIvjDtbHsulLDL9iUriGbu9el/NOru?= =?us-ascii?Q?vRa28fvEEYeY+oFbMsijJRXqW9ln6uL9RfMjZkBuNaqSzVDi5AZkr2NtQOlo?= =?us-ascii?Q?IvjBRCpFSFAi51HO/gEgo6AbYSWNpDIiRpdDbXYnf42E9SLe71D+ogngWhC7?= =?us-ascii?Q?gNk3s7HWy6tAtYdwiamtU4Lovdf5mTWQpk7rNpVWUAfGR2dPwQi/d7bwk6oE?= =?us-ascii?Q?loxsf5S1QYJTaD4SiS9PWHxGZiDiIK300VgriMFTkqVAAGkAqA5MS2cSm02W?= =?us-ascii?Q?tnd2gAGr0te7Z4BA85XhZsTQZs6TMU6JPtaWLaPOwo1Se9JX/YEx//1ggmdQ?= =?us-ascii?Q?qi8xdkn8jKTtPEFyDTVqmbbTuErXYHzyYUWqAIPdYTWf2wJCvrppXhFmfNVK?= =?us-ascii?Q?meE04T/3Ombu4wMApAt4dVRcS+1vefbEsoleFQ1YMrwf6dpZnQae3EwDpJQz?= =?us-ascii?Q?HLNZ1HsrwCKzPDSKuAU4rJc6m7j0JckK9ClR00ShqQf16MZhLpMaORx1/4io?= =?us-ascii?Q?TCcOtcwIY7E+z+E9D8ec4y90/UZbXk8M9ed3Xz8w4vkh/e+TIRYZd/Ojnyhe?= =?us-ascii?Q?OIuShSlkYrTVJF5tvfu18/5n4Jr5MZ1cQjvr4MQL2/mK8btXa21yDIp+5LxX?= =?us-ascii?Q?dHVIo9Kjz6ltqUGRlqYPe9w0L4dq2oezKRn+Phts4GFF8jwy9+uQn2JFsg0o?= =?us-ascii?Q?nsCnmlro6bkrT2JVpUPSsZNz2IDM6a25bj/mOECGBJcqLwvjDNcXwfokGIe3?= =?us-ascii?Q?Bd1dD40dq0OfmH9EMlSHA5l+IWqPbJ3OxXD9YP7rN6/CCJwen8ENh1M/a5oZ?= =?us-ascii?Q?5PIyxl3hYAkUNHfTuRvFyb+Ecn1hc3Fl2qMlgp3BCB37tjHyTYMWLTuXSmvf?= =?us-ascii?Q?xGfN+pRMEt1Q1fyk01B9j8JTtSNj/gp9R0pl829/lXeqz7EFl3L4DM9Oa++E?= =?us-ascii?Q?XLM35qwJ+TQo3NfPf76vrHca+wBZ59tSStJnO7+22mosvWLUhvwg0J3zwkUu?= =?us-ascii?Q?RBHt+rKLS1xV+ZU4/UgbyCuguXKC11WTGal/87HHuTHRvBdoVpBWwERy95vr?= =?us-ascii?Q?NZTFDK6spl+BjtnAg7fVba8p1RCcIhGT3BANSmhiYAJjGzofE7E+1We+UPSp?= =?us-ascii?Q?3gewgpGYm8AFUg7i8QbVENeD4JFlzsHgYCseC3VvI12CYIuD83N+zlm/h3HV?= =?us-ascii?Q?y1T/Eqt6Y6rgw5W4kpvtma41fec7otnS0DuHQkRpuA3ESQ38vxcjg+8famAy?= =?us-ascii?Q?p+9w8Qphq8fHUfZifNbU94FSU9ipKMez2uqakLzpaOLtTbje7j7fPSICf0la?= =?us-ascii?Q?JVBOrsizg/u2Q8w/dHlc6+d8MKiha/2/lXhAckdkwlQV9JJ/rNo+SdLvNKg+?= =?us-ascii?Q?7l6eU/pSiWrzhPNB7LoUaHth/jL6XsPoAlSE9uHNcKkf3HArwL5xrlPcRG8X?= =?us-ascii?Q?Xc0fAZV0gvktZl4JLgb03mk=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7243d615-f601-4ebd-e1ad-08da95506572 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 06:22:56.0171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8yhds+ZDYEXY+toZrQl8RiiI0jMHqJtQevHhmU4qM2+V0D832rtJ0JRYF+XflKhRr/sV7EhU3fAMHEgDf3aRDD3mBn1nJQJHhRXMoJGl3gs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB3644 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Minh Nguyen This patch removes redundant updates of "BoardManufacturerType02" and "SerialNumberType02". Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index f61546955f12..3441e7798860 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -120,16 +120,6 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer)= { STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER),=0D SerialNumberType02=0D );=0D - OemUpdateSmbiosInfo (=0D - mSmbiosMiscHiiHandle,=0D - STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER),=0D - BoardManufacturerType02=0D - );=0D - OemUpdateSmbiosInfo (=0D - mSmbiosMiscHiiHandle,=0D - STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER),=0D - SerialNumberType02=0D - );=0D OemUpdateSmbiosInfo (=0D mSmbiosMiscHiiHandle,=0D STRING_TOKEN (STR_MISC_BASE_BOARD_SKU_NUMBER),=0D --=20 2.25.1