From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.78]) by mx.groups.io with SMTP id smtpd.web12.2467.1663058951262299031 for ; Tue, 13 Sep 2022 01:49:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=a2SULHLs; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.78, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2XTEnvfdqArg94EpxoYLJeVVP+SjrqFqeJ6851wD3nwO5C3SuXdRSayPKtUYNQBqX9RW/O4BrfyUU04jklIOv/MtZNuC3DoAReceBT3y8Yl9t4cf6l0ZMVvXASjK7IUJNJb0JFCcxq5PHxAM2PpREw8Z9cyP7NOf1/mIdn/T0udO5bECJLtoLLqlpCmTGFFc/vsXBptJ0ruAlLHbpZ43sK8iWrZxCF3Xkok5cazgN//98GasGT4VHq9+Sirdjs+WNCcPE3/ffLGBR+FLAvQuDOJkTB2in+HO+tVBli3wPrGnPthv/nChBCDANn+4ONXMfgb3ZzGa/VOAa1kIq5bhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a83+XzaGf3NxJlDUKB/bbtDtIvQO4o7NauSKTnelDMY=; b=MhNFuOtrTZuIK/oMKC6itq3RtWrPfPwQ2pKxwle6b7mZ/s/8vatgcwzp4oyvYmLAQv3LpjFSIVtyct/Y0pcVI68ndTIA9cVdRKmlp+uiQ+7hqb3XTLqD8Ie39DcWs41lQjIXgN1dBmUt13mw1jlxypCG+U9hldxQCt1Tixdjg9FrmZLslTiwazEoyYxLPSsSPtFDaPnAU5jp2rqII97fBOXQOgsG+7Dv9dKePE0nRba+EP01b6TqhZNTigBPWPyJHuNMJXZbdKO3Ig2t0vkcGjh/zqCNob7lBZmXM7VXJTKyD9SKL7FDvBWCzf1ACkx0XWD/ZemJ4lCS8ubaPZsh7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a83+XzaGf3NxJlDUKB/bbtDtIvQO4o7NauSKTnelDMY=; b=a2SULHLsSmTXMiaBvi8ouzMXH94mWPZ5L2o5PV8tznHsefLE8L1EvwnT56sdN0WF9ONZF0Jp0YVbOkTTYfGxQKn9zgPJB7vppJku2xOBVb8JsaLbAL8ud1WlcbkgPNwA+leTqeHiiaBKyr4pPJIh4EyyTnQ8pysUeKxnq31rjRA= Received: from MW2PR16CA0057.namprd16.prod.outlook.com (2603:10b6:907:1::34) by SJ0PR12MB6901.namprd12.prod.outlook.com (2603:10b6:a03:47e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 13 Sep 2022 08:49:08 +0000 Received: from CO1NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::a6) by MW2PR16CA0057.outlook.office365.com (2603:10b6:907:1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22 via Frontend Transport; Tue, 13 Sep 2022 08:49:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT038.mail.protection.outlook.com (10.13.174.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 08:49:08 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 13 Sep 2022 03:49:03 -0500 From: "Chang, Abner" To: CC: , Abdul Lateef Attar , "Garrett Kirkendall" , Paul Grimes , Eric Dong , Ray Ni , Rahul Kumar Subject: [edk2-staging/SmmCpuFeaturesLib_AMD][PATCH 0/4] Reconstruction on SmmCpuFeaturesLib Date: Tue, 13 Sep 2022 16:47:57 +0800 Message-ID: <20220913084757.800-1-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT038:EE_|SJ0PR12MB6901:EE_ X-MS-Office365-Filtering-Correlation-Id: 5aaad26c-1885-416f-5a8c-08da9564d250 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bYOq6AKzLQliwIwK6wBwlb0yWqt6MCAc1Xe3qsqpwyqti4/Nlnq3EmjZhx8REfeQjFVDUfpSfWaKaJrSrY6CaVVJnA7/XFREIiYiatTqcm8qlhtIg5cQUDKRxwsKQH5a1MkCtXEsH+OM2YN5w7+AwaA3rkTPygrARV6Yk4mVOGPLdcX6CSCyQYHoC4yBClRWiUedFjuOeBWULRCSJOQSlZd+51LGMICRQGb/ek5OjzLB/TPUHLMy3s3PWleIKR+0d3pwUsc1cQZIOBYcA6Bc4S3YtMzq5MjUF7C+PUh2ZS9qdmSa3fgrpTcWPT0+l4D8a9gOE6F6VU8WeawRWTeFiMOtDu8pWns7Y0+qL+xVAN589em3HuOP/X/57m2Cs0Q6UvC6zKYNFmqL7PQ54u8oj5DjG5g2JqhJYpK3mZPUPHuXqNVatmqloDee1TaVdEtiNJocoqhtNEM849bnArVrqhmGMvoTMDKpTH9gD7/dtl1eSUhNJzhAG2R7YOLEoKImQvaiJDbYtaeAHRVDjuz2WEjnoMMyzYaPHAdB5WJXtrwDYEcD3bcJJhtfpxC5ilOtYUoCPlGIPT+RyQoD3bTfglqw8DxuXrh0cB/nBpvGy0Y+aS6YeqdD542urJ+vBW2rdb1Q8vyOAiw9fltVt/hCi1ViZACbxYB0Sc0BtxfDnh2M/xYEhEXM9fyvwfgIkSC4C+zYTBu9KweojSI/IQH9lJpP9+RebhKrT4J8CMtMWo2LfER3u90tpzcMBtPL1kL5ubcLsCl/2qUUq/09dcF6gdaHpcg86CbR6lSZRud0O2rTYPwUdf2vHfmwa6TWd5aolf8yCSAMqBEDP9vgemWxSg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(16526019)(336012)(54906003)(6916009)(36756003)(1076003)(478600001)(966005)(8676002)(70206006)(316002)(2876002)(83380400001)(36860700001)(82310400005)(70586007)(19627235002)(356005)(26005)(40460700003)(4326008)(7696005)(40480700001)(8936002)(5660300002)(47076005)(2906002)(186003)(81166007)(2616005)(82740400003)(426003)(6666004)(86362001)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 08:49:08.2377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5aaad26c-1885-416f-5a8c-08da9564d250 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6901 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang This is the reconstruction on SmmCpuFeaturesLib to accommodate AMD implementation of SmmCpuFeaturesLib. A new folder \X86 under SmmCpuFeaturesLib is created for X86 architecture, this gives SmmCpuFeaturesLib a well folder structure for not only X86 but also for other processor architectures. There are two cases that can trigger the reconstruction on the modules (not only SmmCpuFeaturesLib) under UefiCpuPkg, 1. Create the X86 folder to accommodate both Intel and AMD implementation, with this AMD implementation can leverage the modules design and source files. 2. Create the X86 folder for X86 architecture when the new processor architecture is added to the module and leverage the module design and source files. For example, the upcoming RISC-V and loongson processor architecture. This patch set is also part of below BZ 3860: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3860 This reconstruction keeps all INF files as where those are, which prevents the impacts on the existing platform DSC that has the reference to SmmCpuFeaturesLib INF file. This patch set is the preparation for AMD SmmCpuFeaturesLib upstream. In the follow up pacthes, AMD will create a new INF file SmmCpuFeaturesLibAmd.inf under \SmmCpuFeaturesLib and pull in the source files that located under SmmCpuFeaturesLib\X86. This reconstruction would be the sample for the follow up reconstruction on UefiCpuPkg modules, if there is no objection from the UefiCpuPkg maintainer and edk2 community. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Garrett Kirkendall Cc: Paul Grimes Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Abner Chang (4): Add X86 folder Abstract arch dependent code Relocate STM files Clean up header file inclusion .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 6 +- .../SmmCpuFeaturesLibStm.inf | 20 +- .../StandaloneMmCpuFeaturesLib.inf | 4 + .../SmmCpuFeaturesLib/CpuFeaturesLib.h | 7 + .../SmmCpuFeaturesLib/{ =3D> X86}/SmmStm.h | 0 .../SmmCpuFeaturesLibCommon.c | 392 +---------------- .../{ =3D> X86}/Ia32/SmmStmSupport.c | 0 .../X86/SmmCpuFeaturesLibIntel.c | 404 ++++++++++++++++++ .../SmmCpuFeaturesLib/{ =3D> X86}/SmmStm.c | 3 - .../{ =3D> X86}/X64/SmmStmSupport.c | 0 .../{ =3D> X86}/Ia32/SmiEntry.nasm | 0 .../{ =3D> X86}/Ia32/SmiException.nasm | 0 .../{ =3D> X86}/X64/SmiEntry.nasm | 0 .../{ =3D> X86}/X64/SmiException.nasm | 0 14 files changed, 434 insertions(+), 402 deletions(-) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/SmmStm.h (100%) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/Ia32/SmmStmSupport= .c (100%) create mode 100644 UefiCpuPkg/Library/SmmCpuFeaturesLib/X86/SmmCpuFeatures= LibIntel.c rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/SmmStm.c (96%) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/X64/SmmStmSupport.= c (100%) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/Ia32/SmiEntry.nasm= (100%) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/Ia32/SmiException.= nasm (100%) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/X64/SmiEntry.nasm = (100%) rename UefiCpuPkg/Library/SmmCpuFeaturesLib/{ =3D> X86}/X64/SmiException.n= asm (100%) --=20 2.37.1.windows.1