public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Isaac Oram" <isaac.w.oram@intel.com>
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Eric Dong <eric.dong@intel.com>,
	Benjamin Doron <benjamin.doron00@gmail.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes
Date: Wed, 14 Sep 2022 11:40:24 -0700	[thread overview]
Message-ID: <20220914184027.1510-1-isaac.w.oram@intel.com> (raw)

The S3FeaturePkg changes in
  [edk2-platforms][PATCH v3 2/4] S3FeaturePkg: Implement working S3 resume

Introduces some build issues with standalone package build for S3FeaturePkg and
AdvancedFeaturePkg.  There are also some type cast related compiler warnings.

We do not currently have continuous integration testing.
We do not currently have documented build testing configuration requirements.
Therefore I am just fixing the minor issues and intend to merge both patch
series together to maintain git bisect to the best of my ability.
I do plan to document required and recommended board port and feature pkg
builds.

Note that the use of UINTN for intermediate data instead of
EFI_PHYSICAL_ADDRESS is only to be consistent with other ACPI implementations
of similar functionality.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Benjamin Doron <benjamin.doron00@gmail.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>

Isaac Oram (2):
  S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg
  MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address

 .../Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc    |  3 +++
 .../Intel/PowerManagement/S3FeaturePkg/S3Dxe/S3Dxe.c   | 10 +++++-----
 .../PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc      |  3 +++
 .../Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.c   |  2 +-
 .../Intel/MinPlatformPkg/Include/AcpiS3MemoryNvData.h  |  4 ++--
 5 files changed, 14 insertions(+), 8 deletions(-)

--
2.36.1.windows.1

             reply	other threads:[~2022-09-14 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 18:40 Isaac Oram [this message]
2022-09-14 18:40 ` [edk2-devel][edk2-platforms][PATCH V1 1/2] S3FeaturePkg/Build: Add libraries needed by S3FeaturePkg Isaac Oram
2022-09-14 18:40   ` [edk2-devel][edk2-platforms][PATCH V1 2/2] MinPlatformPkg/S3: Use EFI_PHYSICAL_ADDRESS for address Isaac Oram
2022-09-28 16:16 ` [edk2-devel] [edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Benjamin Doron
2022-09-28 17:22   ` Isaac Oram
2022-10-11 23:40 ` [edk2-devel][edk2-platforms][PATCH " Nate DeSimone
2022-10-12  1:33   ` Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220914184027.1510-1-isaac.w.oram@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox