From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.14492.1663268130574646724 for ; Thu, 15 Sep 2022 11:55:30 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=ODi+vPcZ; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 1D58D2047786; Thu, 15 Sep 2022 11:55:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1D58D2047786 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1663268130; bh=JCWqmzZ+wOZLhmCR2IZDU3S0nkCMfsfvy9seaqx9kg4=; h=From:To:Cc:Subject:Date:From; b=ODi+vPcZCCIhOyXEjw41EvVokxmLHBkxy6T5sBEU2IklR9w+GE5rPs0qcWHILsBfP EQ97sCTlaNTYvn6/mmmXMid60b8WJurrm2rV1sPSUOx+mtO9UpL7MXjo4p7N01lG2M GwlGlUU6L5tzwUqJz3oeqX3bI5ZtggiFFXrJfxko= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Liming Gao , Michael D Kinney , Nate DeSimone , Sean Brogan , Star Zeng Subject: [PATCH v2 0/6] Enable CI in Intel FSP Packages Date: Thu, 15 Sep 2022 14:55:02 -0400 Message-Id: <20220915185508.997-1-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 - Enables CI in IntelFsp2Pkg and IntelFsp2WrapperPkg. - Fixes several pre-existing issues that impact common CI checks. You can find the CI results for the packages with this change in the following edk2 PR: https://github.com/tianocore/edk2/pull/3347 V2 Changes: 1. The pre-existing compilation issue in IntelFsp2Pkg that caused the following BZ to be filed in v1 is now resolved. Therefore, the compiler CI plugin is enabled in IntelFsp2Pkg now. https://bugzilla.tianocore.org/show_bug.cgi?id=3D4049 2. The following patch is dropped from v2: [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Chasel indicated this is an intentional design decision so platforms do not have to override the entire library instance during platform integration. Consequently, "FspWrapperPlatformMultiPhaseLib" was added to the ignore list for the "LibraryClassCheck" CI plugin in IntelFspWrapperPkg.ci.yaml. Rebased series on f46c7d1e36c9 and added v1 R-b tags. Cc: Chasel Chiu Cc: Liming Gao Cc: Michael D Kinney Cc: Nate DeSimone Cc: Sean Brogan Cc: Star Zeng Signed-off-by: Michael Kubacki Michael Kubacki (6): IntelFsp2Pkg: Fix code formatting errors IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID IntelFsp2Pkg: Add CI YAML file IntelFsp2WrapperPkg: Fix code formatting errors IntelFsp2WrapperPkg: Add CI YAML file .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c = | 9 +- IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c = | 2 +- IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/FspWrapperApiLib.c = | 4 + IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/IA32/DispatchExecute.c = | 1 - IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInit= Data.c | 8 +- .azurepipelines/templates/pr-gate-build-job.yml = | 3 + .pytool/CISettings.py = | 2 + IntelFsp2Pkg/Include/Ppi/Variable.h = | 8 +- IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml = | 90 ++++++++++++++++++ IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf = | 2 +- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml = | 96 ++++++++++++++++++++ 11 files changed, 210 insertions(+), 15 deletions(-) create mode 100644 IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml create mode 100644 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml --=20 2.28.0.windows.1