public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: [PATCH v2 1/6] IntelFsp2Pkg: Fix code formatting errors
Date: Thu, 15 Sep 2022 14:55:03 -0400	[thread overview]
Message-ID: <20220915185508.997-2-mikuback@linux.microsoft.com> (raw)
In-Reply-To: <20220915185508.997-1-mikuback@linux.microsoft.com>

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048

This package did not have CI enabled so code changes were merged
that fail uncrustify formatting. This change updates those files
to include uncustify formatting.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
---
 IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c      | 9 +++++----
 IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c | 2 +-
 IntelFsp2Pkg/Include/Ppi/Variable.h                            | 8 ++++----
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
index cb2317bfb240..8e24b946cd88 100644
--- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
@@ -193,8 +193,8 @@ DebugBPrint (
 **/
 VOID
 FillHex (
-  UINTN   Value,
-  CHAR8   *Buffer
+  UINTN  Value,
+  CHAR8  *Buffer
   )
 {
   INTN  Idx;
@@ -227,8 +227,8 @@ DebugAssertInternal (
   VOID
   )
 {
-  CHAR8   Buffer[MAX_DEBUG_MESSAGE_LENGTH];
-  UINTN   *Frame;
+  CHAR8  Buffer[MAX_DEBUG_MESSAGE_LENGTH];
+  UINTN  *Frame;
 
   Frame = (UINTN *)GetStackFramePointer ();
 
@@ -250,6 +250,7 @@ DebugAssertInternal (
       sizeof (Buffer) / sizeof (CHAR8) - 1
       );
   }
+
   SerialPortWrite ((UINT8 *)"ASSERT DUMP:\n", 13);
   while (Frame != NULL) {
     FillHex ((UINTN)Frame, Buffer + 9);
diff --git a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
index 69a021f42b39..a0b2193bdeab 100644
--- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
@@ -31,6 +31,6 @@ SwapStack (
 
   FspData            = GetFspGlobalDataPointer ();
   OldStack           = FspData->CoreStack;
-  FspData->CoreStack = (UINTN) NewStack;
+  FspData->CoreStack = (UINTN)NewStack;
   return OldStack;
 }
diff --git a/IntelFsp2Pkg/Include/Ppi/Variable.h b/IntelFsp2Pkg/Include/Ppi/Variable.h
index 3e1f4b98a999..581f14880813 100644
--- a/IntelFsp2Pkg/Include/Ppi/Variable.h
+++ b/IntelFsp2Pkg/Include/Ppi/Variable.h
@@ -184,10 +184,10 @@ EFI_STATUS
 /// to store data in the PEI environment.
 ///
 struct _EDKII_PEI_VARIABLE_PPI {
-  EDKII_PEI_GET_VARIABLE            GetVariable;
-  EDKII_PEI_GET_NEXT_VARIABLE_NAME  GetNextVariableName;
-  EDKII_PEI_SET_VARIABLE            SetVariable;
-  EDKII_PEI_QUERY_VARIABLE_INFO     QueryVariableInfo;
+  EDKII_PEI_GET_VARIABLE              GetVariable;
+  EDKII_PEI_GET_NEXT_VARIABLE_NAME    GetNextVariableName;
+  EDKII_PEI_SET_VARIABLE              SetVariable;
+  EDKII_PEI_QUERY_VARIABLE_INFO       QueryVariableInfo;
 };
 
 extern EFI_GUID  gEdkiiPeiVariablePpiGuid;
-- 
2.28.0.windows.1


  reply	other threads:[~2022-09-15 18:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 18:55 [PATCH v2 0/6] Enable CI in Intel FSP Packages Michael Kubacki
2022-09-15 18:55 ` Michael Kubacki [this message]
2022-09-15 18:55 ` [PATCH v2 2/6] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID Michael Kubacki
2022-09-15 18:55 ` [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file Michael Kubacki
2022-09-15 18:55 ` [PATCH v2 4/6] IntelFsp2WrapperPkg: Fix code formatting errors Michael Kubacki
2022-09-15 18:55 ` [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML file Michael Kubacki
2022-10-04 16:01   ` [edk2-devel] " Michael D Kinney
2022-10-04 16:21     ` Michael Kubacki
2022-10-05  1:27       ` Chiu, Chasel
2022-10-05  3:08         ` Michael Kubacki
2022-10-05  3:59           ` Chiu, Chasel
2022-09-15 18:55 ` [PATCH v2 6/6] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI Michael Kubacki
     [not found] ` <17151D8FB6D820D9.18791@groups.io>
2022-09-15 19:41   ` [edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file Michael Kubacki
2022-09-23  1:07     ` Michael Kubacki
2022-10-03 14:44       ` Michael Kubacki
2022-10-03 18:46         ` Michael Kubacki
2022-10-04 16:02 ` [PATCH v2 0/6] Enable CI in Intel FSP Packages Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220915185508.997-2-mikuback@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox