From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.14229.1663268140149772318 for ; Thu, 15 Sep 2022 11:55:40 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Mu2kJTSV; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 5099620B929C; Thu, 15 Sep 2022 11:55:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5099620B929C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1663268139; bh=oZ1qSpCv/jqLEkA9CrkuUffWQ3Wml4qtbDUJYAy8OZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mu2kJTSVn275jtX2j8XPBkL5yLXuoQDAxNLFmmIvMv6xtk16+deN4iVQ37fk3wIJQ x0Uvc2vl93PmQ44dvp/HfbsWUlh59KegzXTmTCvokpqnH9edT1nHP0AaX8cz6UQKjh hwEY49j50uNh9NzM+3ncmCi6BPymLQFlT0AiWacE= From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file Date: Thu, 15 Sep 2022 14:55:05 -0400 Message-Id: <20220915185508.997-4-mikuback@linux.microsoft.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20220915185508.997-1-mikuback@linux.microsoft.com> References: <20220915185508.997-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 Adds IntelFsp2Pkg to the list of supported build packages for edk2 CI and defines an initial set of CI configuration options. The compiler plugin is disabled as the package currently does not build due to some changes in the FSP 2.4 interface addition. Specifically, in commit df25a54 "Fsp24SecCore.inf" files were added to IntelFspPkg.dsc but the actual files were not added. Simply removing these files from the DSC exposes a linker failure. Recommendation: 1. Enable package CI (accept this change) 2. Add IntelFsp2Pkg.dsc to the "CompilerPlugin" "DscPath" in IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml to enable compilation 3. Verify compilation and all currently enabled package CI checks pass 4. Check-in fixes in (3) with change in (2) Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki --- .pytool/CISettings.py | 1 + IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 90 ++++++++++++++++++++ 2 files changed, 91 insertions(+) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index cf9e0d77b19b..0205c26a58f8 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -54,6 +54,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsMa= nager, SetupSettingsManag "ArmVirtPkg", "DynamicTablesPkg", "EmulatorPkg", + "IntelFsp2Pkg", "MdePkg", "MdeModulePkg", "NetworkPkg", diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml b/IntelFsp2Pkg/IntelFsp2Pk= g.ci.yaml new file mode 100644 index 000000000000..9ce401b20164 --- /dev/null +++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml @@ -0,0 +1,90 @@ +## @file +# Core CI configuration for IntelFsp2Pkg +# +# Copyright (c) Microsoft Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +## +{ + ## options defined .pytool/Plugin/LicenseCheck + "LicenseCheck": { + "IgnoreFiles": [] + }, + + "EccCheck": { + ## Exception sample looks like below: + ## "ExceptionList": [ + ## "", "" + ## ] + "ExceptionList": [ + ], + ## Both file path and directory path are accepted. + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/CompilerPlugin + "CompilerPlugin": { + "DscPath": "IntelFsp2Pkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin + "HostUnitTestCompilerPlugin": { + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/CharEncodingCheck + "CharEncodingCheck": { + "IgnoreFiles": [] + }, + + ## options defined .pytool/Plugin/DependencyCheck + "DependencyCheck": { + "AcceptableDependencies": [ + "IntelFsp2Pkg/IntelFsp2Pkg.dec", + "MdeModulePkg/MdeModulePkg.dec", + "MdePkg/MdePkg.dec", + "UefiCpuPkg/UefiCpuPkg.dec" + ], + # For host based unit tests + "AcceptableDependencies-HOST_APPLICATION":[ + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec" + ], + # For UEFI shell based apps + "AcceptableDependencies-UEFI_APPLICATION":[], + "IgnoreInf": [] + }, + + ## options defined .pytool/Plugin/DscCompleteCheck + "DscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "IntelFsp2Pkg.dsc" + }, + + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck + "HostUnitTestDscCompleteCheck": { + "IgnoreInf": [""], + "DscPath": "" # Don't support this test + }, + + ## options defined .pytool/Plugin/GuidCheck + "GuidCheck": { + "IgnoreGuidName": [], + "IgnoreGuidValue": [], + "IgnoreFoldersAndFiles": [], + "IgnoreDuplicates": [], + }, + + ## options defined .pytool/Plugin/LibraryClassCheck + "LibraryClassCheck": { + "IgnoreHeaderFile": [] + }, + + ## options defined .pytool/Plugin/SpellCheck + "SpellCheck": { + "AuditOnly": True, # Fails right now with over 270 err= ors + "IgnoreFiles": [], # use gitignore syntax to ignore er= rors in matching files + "ExtendWords": [], # words to extend to the dictionary= for this package + "IgnoreStandardPaths": [], # Standard Plugin defined paths tha= t should be ignore + "AdditionalIncludePaths": [] # Additional paths to spell check (= wildcards supported) + } +} --=20 2.28.0.windows.1