From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.107]) by mx.groups.io with SMTP id smtpd.web08.15779.1663554133247290766 for ; Sun, 18 Sep 2022 19:22:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=gOzHemBe; spf=pass (domain: os.amperecomputing.com, ip: 40.107.96.107, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjwRjWxKsopVSyOzolOdvOryXsVIVE8c7WO02nHGCRx11oQPo9Y+WjNUfxqWOvFBxjW/33qqkkyKpgVSXJcDKOUIJTP90DwLyudlIabyl/RFgJoc+paJwQfaukr6NXWm7eXRvvpfJOHYVAiYn9i327druxQ7x3e7rHS4iJQqCdMFMIw6RIUIVRr0dPUxg+4v34BXhkcXXfFfW3mHvt8B806DzBddzBFjWeQY/6vQY+byGjry8LE04X9Ol3OFn4JXa2dFgyfVNKLsbusc5jR3NAV5fTlp0+lvG9HNRimFu8b/1DBz7500dcnxnaPrr69/LCBidVLPiLZB53z5Vl0p1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=67JiAfOawA7iPm7dI40qwTP+eTdajboX8jueVFhGnNU=; b=ByB5AQcWs65Z6pLafBlLPuByosaPjQTI5qVJpv8bOP8XKzzjHgBFU1n9cu4ttuvGxlWXaWkHkHsVh7kesNr6pYTcaApbG6Y2H3dUoiYiVvtiPhaeGeKG0kL3sL9IEQ9Y7uKgzSx9Z+jMCqW5XBhv6Lx2cc7J5WwbjqQoEJDTvZOEL3r5ryXRmfMm6QRL8rzoovo6KTupjzIPgRKRoezb5eXumjkifnnNj6GAiS1FcPCeIiMzwJul2Sy5HTNMmWqjTf7inaSsGMUAntIoHRdCovSGPyQo3W2ddNRQ+VVpuHoYS2D/C1G/8iYcTEm9q/ZWIyv7+k7RxZ2QET20NSwPjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67JiAfOawA7iPm7dI40qwTP+eTdajboX8jueVFhGnNU=; b=gOzHemBemAOgcZJiSLY2x6jpbMtpHgRf59NmfnooiBnlzaGZO7iSCugyZYT+8OneRrPo8rQbEcx+YpolDzG/02w3gcSLvz9lcwAAaHGps8bThzOMj5/brclmG6bdns3boXd46WsTIUovYGyW+tqXbewzAWzdFhXDh+2SQ7EF2dk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by CO1PR01MB6791.prod.exchangelabs.com (2603:10b6:303:f7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Mon, 19 Sep 2022 02:22:11 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::441a:930:ac15:1ce9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::441a:930:ac15:1ce9%4]) with mapi id 15.20.5632.019; Mon, 19 Sep 2022 02:22:11 +0000 From: "Nhi Pham" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran , Ard Biesheuvel Subject: [PATCH v4 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib Date: Mon, 19 Sep 2022 09:19:45 +0700 Message-Id: <20220919021950.2110333-2-nhi@os.amperecomputing.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220919021950.2110333-1-nhi@os.amperecomputing.com> References: <20220919021950.2110333-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SG2PR02CA0071.apcprd02.prod.outlook.com (2603:1096:4:54::35) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|CO1PR01MB6791:EE_ X-MS-Office365-Filtering-Correlation-Id: 327e18c9-e7f7-443b-9742-08da99e5c217 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9B0ouUJuIvTsBI2V1Wx62+SszVw9y5rqzVL2G15u6REFZ8oRxq6352PT7THiMhnVgg2LDn9oVBq66lqBzG+qKyIL4Y9MyaCSwmhClccLA7dxi7hwkPNRLgrG/QlFjje9Lc8gzbnRr3QahEj5kiKfXaNaZKwU9GHL8RI/mNgZhg9Q71FLeqeAc20ATiLPkF1Yt/SPCqUHf/DfHkdyfTfBQDt/JX5hG4KhCPXFb1EnBVyxR5Mayb7/uLNrT8aRUioEDDBITl7l4oZ1eivifWW+SWAp/UMBpxitN/WiI4ylQxp7AAunx4B6n8HJW8pdj8+bX1g4S6MmOkIPvwgatCuhRkZh6Tvnqfyse31yPUIqzPn0zPuhVXKFRISQi4zc+ZG/gx4wWu1Yf4mSd3TJ8R+dVr7O00JwnWzgRXISecbFAb9o4OUMHsP3TabhkFl+Mr/Y7t3rdokE9vrMdl4oJlwoAaTJDLAaM58I9IsD2ODEiBQ9q0bB4eZUOZk2sJsFGIpltCtFmH/C4Oj7zOaUyn5xeiDQpq1IKfZguPDzDixuDXaPGCkxJnvQGA5k2pMmDInc3VT7LWCbJGd/ZaoFknLM9KBWyFWH6XEyiwp6DTic8TO44Bs4rq3JRrbCauoxYN9a1tAChqA+dlG8if3lBWCnn8j2jAYacSx6Zxo6xUiWE/8Aqq/4cpo57QV+cT5Lf+YlIgAsluFByuorzvnbXwT+Ch+SjD4yrMQTpxKRLm3QO/CZhrrvf2JuxDSaEgL7WPtIRPJW88FtbY40s0PQ7TGPHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(346002)(39840400004)(376002)(396003)(451199015)(66946007)(5660300002)(8676002)(4326008)(66556008)(66476007)(8936002)(54906003)(86362001)(316002)(19627235002)(38100700002)(38350700002)(83380400001)(6666004)(41300700001)(52116002)(6486002)(6506007)(478600001)(2616005)(186003)(1076003)(6512007)(26005)(2906002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PrCImn0MGLAuuyHqGciDO+pyaTVvfCyn8d1M3RmwVSQfBqlliWLZr+pYmZAz?= =?us-ascii?Q?wGFg73fv6RJY+KT6Ws+ZkBkW8Zf3sebk6oDjrYOuL+g6ISh56+xYu13kvdkV?= =?us-ascii?Q?u7FYF5xP1wehX/1JczvOP77wGP7tDjWznQ/O5IMfseDdNiUUfW8sHB3ea8RB?= =?us-ascii?Q?G3X5uIQJC6uPoYTSePEbwuKdckmautb6Pyu30PxPAOAcxp9sx7M8jTdQI71k?= =?us-ascii?Q?/6bWm+ULG7USAJi4Xwa3zmA1c2PduNYE+/2byeOcad0/WE389CvzzIhXz+Cd?= =?us-ascii?Q?tz1bY0uuy62iFIQPPNhVL5hI59o00hocT3keqoY01REY6SAgFBsDxUBHt+Qn?= =?us-ascii?Q?754qaCU25kKw982RkZ79qZ9DotN2R6B0LDqeHHJkmrOdi6TlEZ5lyT2KznBm?= =?us-ascii?Q?Ou4fhjXg0fJtjEC67NK0I+EBJX7uKsxYkqpi15B/WKIK1vofsKiTGXkRzssS?= =?us-ascii?Q?QMIo0XZWJwkjeuoa4tNw/NnXPXtstZy9+vYnZ4J8MeQel4Ri7soImWbodtWy?= =?us-ascii?Q?WUbcVL4kafixAGVw6BMGEC8aUfNYyFceafAqODwx257xWqfrjSwk4H6m7mav?= =?us-ascii?Q?bDLCkl3TPPVuToH4Qtepdgxd9bgU/MxomKgoXW+eFgAbhfI0O3TjeYXdV5as?= =?us-ascii?Q?txZleopdzHPt7NQT0fd6l6Kgn2lITJZTWp74bO3VyI28eFzmC9ilXjpOqx25?= =?us-ascii?Q?XX8hpKM+qodAXXyLv9Wq5UWeu1u5L77L4HAjm/tQTYtmESfVpdiWUMfXH9Z2?= =?us-ascii?Q?hf29LkO66S4/cEh1iG3qbmeGk9BHFu01VXtFOEvpKaCtpo0nvZZBCyQvBbQE?= =?us-ascii?Q?b75v12KtbcPhHdoeSCitDWerMV+2AMv4lJW9DAA7E29KQAcfiRK17XfJ97cn?= =?us-ascii?Q?6EGlCIz0CrefwkNqzRLYLCmLJXj10KaWDCNonEFfZ8IlPz9rNEXb1AftpoO0?= =?us-ascii?Q?0SwWTtKbu5sXtt7hX3ZAc/nRTdYvWeppFe6Xw9eOFtWdZK2NB7PwwGga5WY/?= =?us-ascii?Q?iDIwEsQ8jZCosPIWdxsOibrLHAZG00DD/qbjJT5pTQW4Cqs0Brl51F+Wh5bv?= =?us-ascii?Q?Bro8gWEr+tvd3XjaBpe+Y9ZIToABOGLCkJsjN2ELhPiCxdWQzOb5mKhk7w+5?= =?us-ascii?Q?FZncweXZnzzuRIC2xR7zE6Ajs0EZwxz8KyWS8+W5ePuLD3TfneEoTFedNQIU?= =?us-ascii?Q?hgP1iuQKtdFeXB7gRSKd9knqaFmI801s7y23j47wUKFC6SiQBpO+wsvn1joI?= =?us-ascii?Q?BF1HYY4hO3G4R7Y5QRstycEfx0OdHpYXJhL4YTWDUCmWushj7pTXu+bbwUHz?= =?us-ascii?Q?Qk7n9dEoCeI4fy4cGD4QL/yDGmAunyC2QTaQpiC+/OF8rTq3rSrsWIWH3X7I?= =?us-ascii?Q?3HiZA8jtI9L9l6Yz3bZFjXhHNDVyswLlO3/1fIoo0X9LzOGzVN3qv9rh1JPU?= =?us-ascii?Q?H3XHKoWM2s3yxaiwngfNkoO6ghb2Nz0uIl6UWdgFgMm47T8dPoL1IvWublZB?= =?us-ascii?Q?mmyvTHFslyAmyVtP46Q3Df43iMnMWz9cKnhG/0N1QhzyRco3Ob9gg4hRWVhs?= =?us-ascii?Q?5+8J8rAy7e2ERzr0CLvFCsTATl1Jz9tIm3p3RtdoDNjNENK1FyPU0ppVF0VL?= =?us-ascii?Q?IeglZDSwfuYLKjZaYjnu6n8=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 327e18c9-e7f7-443b-9742-08da99e5c217 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 02:22:11.1732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HiYTHbzXABlgsV8beqk+hCtY9tqtEKnW4cLuUlrdtSF0vPP6BTjWgz4ELtWRZiuZNHaUr7Ob9Q2oMFCZ1F3QjxkXhXnwMS69qqaC8iSlwMQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6791 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Minh Nguyen In some scenarios, the processor version may be updated dynamically from pre-UEFI firmware during booting. But the processor version is fixed with PCD (PcdProcessorVersion), so it can not be updated it dynamically. This patch will support setting that value both statically and dynamically. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel Acked-by: Leif Lindholm --- ArmPkg/Include/Library/OemMiscLib.h | 2 ++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 8 +++++= ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 47cb30d84a62..330bb4b014de 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -1,5 +1,6 @@ /** @file=0D *=0D +* Copyright (c) 2022, Ampere Computing LLC. All rights reserved.=0D * Copyright (c) 2021, NUVIA Inc. All rights reserved.=0D * Copyright (c) 2015, Hisilicon Limited. All rights reserved.=0D * Copyright (c) 2015, Linaro Limited. All rights reserved.=0D @@ -58,6 +59,7 @@ typedef enum { SkuNumberType03,=0D ProcessorPartNumType04,=0D ProcessorSerialNumType04,=0D + ProcessorVersionType04,=0D SmbiosHiiStringFieldMax=0D } OEM_MISC_SMBIOS_HII_STRING_FIELD;=0D =0D diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass= .c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c index 0b9af9bd7e1c..3b12e26abf6e 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c @@ -1,6 +1,7 @@ /** @file=0D ProcessorSubClass.c=0D =0D + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.=0D Copyright (c) 2021, NUVIA Inc. All rights reserved.
=0D Copyright (c) 2015, Hisilicon Limited. All rights reserved.=0D Copyright (c) 2015, Linaro Limited. All rights reserved.=0D @@ -512,7 +513,6 @@ AllocateType4AndSetProcessorInformationStrings ( PartNumber =3D STRING_TOKEN (STR_PROCESSOR_PART_NUMBER);=0D =0D SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorManufacturer, ProcessorManu= );=0D - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorVersion, ProcessorVersion);= =0D SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorAssetTag, AssetTag);=0D =0D if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorSerialNumber)) > 0) {= =0D @@ -527,6 +527,12 @@ AllocateType4AndSetProcessorInformationStrings ( OemUpdateSmbiosInfo (mHiiHandle, PartNumber, ProcessorPartNumType04);= =0D }=0D =0D + if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorVersion)) > 0) {=0D + HiiSetString (mHiiHandle, ProcessorVersion, (CHAR16 *)FixedPcdGetPtr (= PcdProcessorVersion), NULL);=0D + } else {=0D + OemUpdateSmbiosInfo (mHiiHandle, ProcessorVersion, ProcessorVersionTyp= e04);=0D + }=0D +=0D // Processor Designation=0D StringBufferSize =3D sizeof (CHAR16) * SMBIOS_STRING_MAX_LENGTH;=0D ProcessorStr =3D AllocateZeroPool (StringBufferSize);=0D --=20 2.25.1