From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web12.4805.1663623558501874039 for ; Mon, 19 Sep 2022 14:39:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=f055Ow7q; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A8F315C03E6; Mon, 19 Sep 2022 17:39:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Sep 2022 17:39:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1663623557; x=1663709957; bh=vdG8r+3rJt6FYW+Ra+N/YhYKQ 4S2OcD67NtnF4rwXzs=; b=f055Ow7qV9TaIHjXCRs5RxNHKSPI2px2o4r6E6YK/ 2O0TLPofN4pvtaomr7jpMBsLKOXc7lqhBbNz/hzASGXbkGxs7hzWhvxIZbAO+DZa VIXqfGpw12briE/wfLEL14D30Ej4ndD4X5sO8R7eIUcd94ECb8z/I8qwXMir53tU o7kknUTYgZzPmwwY43iBfqiQxUKxmAvcfiqTwS3iPlmZkRieDheHkuCQtBxbC3id M0BqqapN8DzJdfWqqB6MZlCTlQRqwknBgpPlLhUvZvV6A8BCsvqYW2itLuqemiMZ tllyeibSQjeVLUO0N7FpgOwl52jXmDEcuZQ7exZ9b1MMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1663623557; x=1663709957; bh=vdG8r+3rJt6FYW+Ra+N/YhYKQ4S2OcD67Nt nF4rwXzs=; b=B3Js28VH+P+S7fILorVfc6HOwu0/+rlMpPhoFWLbDrfAZJ2Z8oX luprt0Lr6lbg6+WFMbLEATnPkHk+LfwRorir+2FAlp5LyJlSIdBwTOKwKC57SuuZ Hy/7M3t7hjG2QN5A8EY7Xq0sZP2euWPUQi0g03iuvKHz4u+GBTZCKgGkftS+b+YI Q3PP2zhJbNQqV1/Dy8sxYh63u36OSMlb91E3eLgKt7lS8OhaRb3vYlY5X0/+MuQG mC2sQKwzfTR6gA9EBXjtfYiNFYLAv4FmLh77tpKma0ttlmtFD+WICdAR0Dyk0E0I nWTgPySU84iVd8ElLrN4PEO+AqbaTv7Ging== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvkedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheptfgvsggvtggt rgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrthhtvg hrnhepuedvkedtleekueekgfejjeettefftdduiefffeehveefgfevueelgffhleelgfdv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsg gvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 17:39:16 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen Cc: Rebecca Cran Subject: [PATCH 1/1] BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile Date: Mon, 19 Sep 2022 15:39:10 -0600 Message-Id: <20220919213910.51063-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When checking if $PYTHON_COMMAND exists, curly braces should be used instead of parentheses. Also, "1" causes an error on FreeBSD: it's likely supposed to be 2>&1 like other scripts. Signed-off-by: Rebecca Cran --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile index 1cb77f84b1bf..caa4d26c9ba6 100644 --- a/BaseTools/Tests/GNUmakefile +++ b/BaseTools/Tests/GNUmakefile @@ -8,7 +8,7 @@ all: test test: - @if command -v $(PYTHON_COMMAND) >/dev/null 1; then $(PYTHON_COMMAND) RunTests.py; else python RunTests.py; fi + @if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then ${PYTHON_COMMAND} RunTests.py; else python RunTests.py; fi clean: find . -name '*.pyc' -exec rm '{}' ';' -- 2.37.1