[edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

[edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

[Vijayenthiran Subramaniam]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479

A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a
dependency to support dynamic variable flash information. Add an
instance for the library class VariableFlashInfoLib in
SgiPlatformMm.dsc.inc to resolve this dependency.

[1]: https://github.com/tianocore/edk2/commit/8db39c60cdf35e0a53ccdbccf7e152ab41f54f4c

Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
---
 Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
index 68fc3ad93a5f..e57b5b75ff73 100644
--- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
@@ -70,6 +70,7 @@ [LibraryClasses.common.MM_STANDALONE]
   SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
   TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
 !endif
 
-- 
2.17.1

Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

Hi Vijay,

Thank you for this patch.
This patch as such looks ok to me but I am getting a build the following failure when openssl library is being built.

build -a AARCH64 -p Platform\ARM\SgiPkg\PlatformStandaloneMm2.dsc -t GCC5 -b DEBUG  -n 1 -D EDK2_OUT_DIR=Build\ArmSgiPlatStmm2 -D SECURE_STORAGE_ENABLE
...
"D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc"  @w:\edk2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\cc_resp.txt  -c -o w:\ekd2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\openssl\crypto\rand\drbg_lib.obj  w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c: In function 'drbg_add':
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c:999:12: error: '+nofp' feature modifier is incompatible with the use of floating-point types
999 | static int drbg_add(const void *buf, int num, double randomness)
|            ^~~~~~~~
NMAKE : fatal error U1077: 'D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc.EXE' : return code '0x1'
Stop.
...

This may not be related to your patch, but can you check, please?

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 1616 bytes --]

Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

[Jeshua Smith]

[-- Attachment #1: Type: text/plain, Size: 2061 bytes --]

It looks like that function call takes a double as a parameter, which is a type of floating point number. I’m guessing that’s why the compiler is complaining that the ‘+nofp’ feature can’t be used with that function.

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami Mujawar via groups.io
Sent: Friday, December 16, 2022 3:29 AM
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

External email: Use caution opening links or attachments

Hi Vijay,

Thank you for this patch.
This patch as such looks ok to me but I am getting a build the following failure when openssl library is being built.

build -a AARCH64 -p Platform\ARM\SgiPkg\PlatformStandaloneMm2.dsc -t GCC5 -b DEBUG  -n 1 -D EDK2_OUT_DIR=Build\ArmSgiPlatStmm2 -D SECURE_STORAGE_ENABLE
...
"D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc"  @w:\edk2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\cc_resp.txt  -c -o w:\ekd2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\openssl\crypto\rand\drbg_lib.obj  w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c: In function 'drbg_add':
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c:999:12: error: '+nofp' feature modifier is incompatible with the use of floating-point types
  999 | static int drbg_add(const void *buf, int num, double randomness)
      |            ^~~~~~~~
NMAKE : fatal error U1077: 'D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc.EXE' : return code '0x1'
Stop.
...

This may not be related to your patch, but can you check, please?

Regards,

Sami Mujawar


[-- Attachment #2: Type: text/html, Size: 4876 bytes --]