From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.4119.1663749088924505576
 for <devel@edk2.groups.io>;
 Wed, 21 Sep 2022 01:31:29 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aDmJY5Fn;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1663749088;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=1ua6HWn7puPsvHVsKg9rur6B4rY0XRD2dXFEe21oQyc=;
	b=aDmJY5Fn8inSRykxbGYbwE+iXYzLazbjilyWN/x74MtsjgzJa2XTjODOcpUd+erOMKXgFq
	iDVfy/WV3AOS/jSxXCqtTNuR9LeK9/Dzz8MMbQweQmZI9PFi4D3DxcKiryOI8WAEwcvHvi
	77O+t0qWqmkq9GYGUTaGXqAHo2lsxQQ=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-63-TNna8ug-MqCHeWvBuYLsMA-1; Wed, 21 Sep 2022 04:31:22 -0400
X-MC-Unique: TNna8ug-MqCHeWvBuYLsMA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB0281C07589;
	Wed, 21 Sep 2022 08:31:21 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.24])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 98720111F3C1;
	Wed, 21 Sep 2022 08:31:21 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 08E4F1800081; Wed, 21 Sep 2022 10:31:20 +0200 (CEST)
Date: Wed, 21 Sep 2022 10:31:20 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Chris Fernald <chris.fernald@outlook.com>
Cc: devel@edk2.groups.io, osteffen@redhat.com,
	Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Bob Feng <bob.c.feng@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [edk2-devel] [PATCH v5 1/4] CI: don't force python verison (Linux only)
Message-ID: <20220921083120.gtihznf3uqtr45mv@sirius.home.kraxel.org>
References: <20220920144524.1098189-1-osteffen@redhat.com>
 <20220920144524.1098189-2-osteffen@redhat.com>
 <IA1PR19MB62757AC3290CA6455812EFEDE74C9@IA1PR19MB6275.namprd19.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <IA1PR19MB62757AC3290CA6455812EFEDE74C9@IA1PR19MB6275.namprd19.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 20, 2022 at 12:41:35PM -0700, Chris Fernald wrote:
> I think we should avoid the expectation that we are in a container if and
> only if we are using GCC5. Instead I would prefer we add a boolean parameter
> to allows us to explicitly use the included python. So instead of the GCC
> check we would have this.

When adding a toplevel container parameter (as suggested in the patch #3
comment) I think we can also simply use that parameter as condition.

take care,
  Gerd