From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web08.11532.1663793104123889500 for ; Wed, 21 Sep 2022 13:45:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fFg7aB5n; spf=pass (domain: gmail.com, ip: 209.85.216.42, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f42.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso6680pjd.4 for ; Wed, 21 Sep 2022 13:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=4DJnbTdKZ68YcVAiAADkG0meHjAgpxkgQ9S5PoJ0QpE=; b=fFg7aB5nYw9Eo6xEbi1Gasoc6uxxg/e//YA2SQ8XE+KZKjHTyhm0KFubcvzTljd+HW yrPKL843ulfi1On2lPSBHrqaxVZ/MokaP0uQRRIFl39yMwZdXPNvvEa06Ts5dRJXrnTY vraj/QnVSIbLGD31HaEApdtXg2nXHy1TGJYWjsJpkgYP5M8/wOiJ5M5hK7mMCmMRL++j dzANsKfhVT+1hDlOnCSDWh0TmXmL1cGfuGF8EBmhnvthpSbpH3jUpKoMTK8qZosN43p9 xjj5iTsbXy8OpqXvn1ssI7t2Qh9gaIdhTM9Fdnm5tXmbzQQ0/CABC/ysteRY8ytbiHO/ HsuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=4DJnbTdKZ68YcVAiAADkG0meHjAgpxkgQ9S5PoJ0QpE=; b=pozrzQu1PzW+n1EaH94Pggwl620GMUV9mCEORoyHEykWPnStJgpps3jBdv6yH4SCID o+3MwnXNR614a9MTvY7vI1TcOYzmEMzwMF4yfTEmYBbXj8bG/iaqikXpHxLigi9srB79 TB8NMuflrD5bmvmqHzaDYe6u3JEf0mIpbVYscCyvp94Aou8Xl8I7BEZ6ZYCtjfrbim3e 0UX5t+5TwjU1vBycpyPcunLADsnEz6GEAPjbhgNnFZMwfwA4/V7ArDTzI2BThZZEy9Ee xkOQlKk1EPcEGwdcspumwOoJjQU6hykPmNAOqVdpTEzrn+a65KEqf10hAhjmkeM3yKTj 2b5w== X-Gm-Message-State: ACrzQf3lY03/gXnDgTpyivyBeg4uAD3V322ahl2JcPr4WGS0sv5uFD1j OD2ayHseGoK11qreK8dHjU9m4DyYARQ= X-Google-Smtp-Source: AMsMyM4VtbUhJoWDGU0/P4XENxEro0FF4zQM4++8qCeB4JZ3xNSvkK6dAEFjyOhR68pBn7k9SN8EHQ== X-Received: by 2002:a17:902:ccc2:b0:178:29f9:5c5e with SMTP id z2-20020a170902ccc200b0017829f95c5emr6252510ple.21.1663793103409; Wed, 21 Sep 2022 13:45:03 -0700 (PDT) Return-Path: Received: from MININT-0U7P5GU.redmond.corp.microsoft.com ([2001:4898:80e8:a:c76:5dc:f08f:1975]) by smtp.gmail.com with ESMTPSA id 78-20020a630551000000b0041bcd8f3958sm2358069pgf.44.2022.09.21.13.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 13:45:03 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen , Sean Brogan Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long Date: Wed, 21 Sep 2022 13:44:59 -0700 Message-Id: <20220921204459.821-2-kuqin12@gmail.com> X-Mailer: git-send-email 2.37.1.windows.1 In-Reply-To: <20220921204459.821-1-kuqin12@gmail.com> References: <20220921204459.821-1-kuqin12@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Sean Brogan Current implementation of looking up toolchain will _insert_ the findings from vsvarsall.bat to existing path and potentially stuff the variable to exceed the length of maximal path length accepted by Windows. This change updated the logic to use the discovered shell varialbes to replace the existing path, which is desirable in the specific use case. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Co-authored-by: Sean Brogan Signed-off-by: Kun Qin --- BaseTools/Edk2ToolsBuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py index 1ea8187de693..f862468ce275 100644 --- a/BaseTools/Edk2ToolsBuild.py +++ b/BaseTools/Edk2ToolsBuild.py @@ -122,7 +122,7 @@ class Edk2ToolsBuild(BaseAbstractInvocable): for key in vc_vars.keys():=0D logging.debug(f"Var - {key} =3D {vc_vars[key]}")=0D if key.lower() =3D=3D 'path':=0D - shell_env.insert_path(vc_vars[key])=0D + shell_env.set_path(vc_vars[key])=0D else:=0D shell_env.set_shell_var(key, vc_vars[key])=0D =0D --=20 2.37.1.windows.1