From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.26073.1664180722740406658 for ; Mon, 26 Sep 2022 01:25:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oIe4y+L/; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3565EB81998; Mon, 26 Sep 2022 08:25:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE164C433D7; Mon, 26 Sep 2022 08:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664180720; bh=62Et7gfQo0zn0JrK1sQEUAc7J1xFF/XEmVHdfRDyVvM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oIe4y+L/B4Cio8a3P8ICvTCTUdsVUSTeA5UCsAvfua3/SYWINNXMvSmEjAOcHITRy RZ/dseteUrtZaC9VM5Qju4euSJyHqH3L/qgk7bkAHXItSGUT+dWmDSEa/Ui2qoMNHc wAWyF432xH36rnUz2d/8/G7Bo2XNVU6wk6nvbKwnHTYBkDD3/503+bC33G9aK2IchN SOc98gdo7Ry1OszbQijtEElZCqgosmxaJiud4fu3lpvc+GfByZ2OeJNzj+H6W4xS/Z f9sUhGe9M9THDbv9vqJNscWffu9uwF2pWx2bIUfbWx8grR14P1tmThCvxzvyHCRLj3 rA+rd4a49hSZQ== From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Alexander Graf Subject: [PATCH v3 02/16] ArmVirtPkg: do not enable iSCSI driver by default Date: Mon, 26 Sep 2022 10:24:57 +0200 Message-Id: <20220926082511.2110797-3-ardb@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220926082511.2110797-1-ardb@kernel.org> References: <20220926082511.2110797-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The iSCSI driver slows down the boot on a pristine variable store flash image, as it creates a couple of large EFI non-volatile variables to preserve state between boots. Since iSCSI boot for VMs is kind of niche anyway, let's default to disabled. If someone needs it in their build, they can use the -D build command option to re-enable it on the fly. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - 2 files changed, 2 deletions(-) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 9369a88858fd..45c4a8fc84e0 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -40,7 +40,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE =3D FALSE=0D DEFINE NETWORK_TLS_ENABLE =3D FALSE=0D DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE=0D - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE=0D =0D !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE=0D !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"=0D diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKerne= l.dsc index 7f7d15d6eee3..66039f07f41b 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -38,7 +38,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE =3D FALSE=0D DEFINE NETWORK_TLS_ENABLE =3D FALSE=0D DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE=0D - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE=0D =0D !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE=0D !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"=0D --=20 2.35.1