From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.26382.1664185013323025581
 for <devel@edk2.groups.io>;
 Mon, 26 Sep 2022 02:36:53 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UWG6RzaU;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1664185011;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/Ipant6MS1y0Ry+SaM/segTimHaNeFfKhWdKj0fb3nY=;
	b=UWG6RzaUoVRUCROb/o/eDWIhlSPBisZkjAqZ5AAQOf1O8RPY8gbgRzFF9wwt0xivFXFXIf
	0PFMIqWLymJ/MIUcNGTCNK/VFdV4mOh2IgGT7r99H+vSXzf0wPGTVr68CHB5FCM8Gi2772
	4s/ZeIjl9v6sbIvPnpWfzAyIvPwDx4Q=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-301-_zkwKnMUME-n7AZZkovkAw-1; Mon, 26 Sep 2022 05:36:50 -0400
X-MC-Unique: _zkwKnMUME-n7AZZkovkAw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DAB329AB3E9;
	Mon, 26 Sep 2022 09:36:49 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.24])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 5356540E9783;
	Mon, 26 Sep 2022 09:36:49 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 1B7141803097; Mon, 26 Sep 2022 11:36:48 +0200 (CEST)
Date: Mon, 26 Sep 2022 11:36:48 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Dionna Amalie Glaze <dionnaglaze@google.com>, devel@edk2.groups.io,
	Ard Biescheuvel <ardb@kernel.org>, "Min M. Xu" <min.m.xu@intel.org>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Erdem Aktas <erdemaktas@google.com>
Subject: Re: [PATCH 0/3] Add safe unaccepted memory behavior
Message-ID: <20220926093648.ohzci7txggqgjqss@sirius.home.kraxel.org>
References: <20220922205052.1198237-1-dionnaglaze@google.com>
 <a0c6dd19-ba27-81b2-8c43-32aa8b01952e@amd.com>
 <CAAH4kHaT31Kk-sMw-o45BoU3=VM=ntY3j2qHZ4jXbvZsA6bSDQ@mail.gmail.com>
 <ef1838f8-0936-2d05-639f-94e89c653360@amd.com>
MIME-Version: 1.0
In-Reply-To: <ef1838f8-0936-2d05-639f-94e89c653360@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 23, 2022 at 02:42:57PM -0500, Tom Lendacky wrote:
> On 9/23/22 14:34, Dionna Amalie Glaze wrote:
> > Ah yes, I did forget to include that patch. Will add to v2. I was just
> > setting the ResourceType to unaccepted and skipping the Prevalidate call
> > in PlatformPei if the start address is greater or equal to SIZE_4GB.
> > That seemed more self-contained than messing with PlatformInitLib. Would
> > you prefer that I add SevSnp logic to PlatformInitLib?
> 
> No, if it works and is easier / more concise, then please keep it the way
> you have it.

Well, moving over the SEV code over to PlatformInitLib makes sense.

That should allow the AmdSev use pei-less boot, simliar to IntelTdx,
and further down the road allow unify AmdSev + IntelTdx variants into
a single firmware binary supporting both SevSnp and Tdx.

I don't think that should be part of the "unaccepted memory" patch
series though.

take care,
  Gerd