[PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

[PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

[Li, Zhihao]

From: Zhihao Li <zhihao.li@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4083

In CPU relaxed mode, it doesn't reset the value of
mSmmMpSyncData->AllApArrivedWithException when BSP exit smm mode.
So this patch will reset this variable.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>

Signed-off-by: Zhihao Li <zhihao.li@intel.com>
---
 UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index 13c2cb8da4c3..c79da418e37c 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -696,8 +696,9 @@ BSPHandler (
   //
   // Allow APs to check in from this point on
   //
-  *mSmmMpSyncData->Counter       = 0;
-  *mSmmMpSyncData->AllCpusInSync = FALSE;
+  *mSmmMpSyncData->Counter                  = 0;
+  *mSmmMpSyncData->AllCpusInSync            = FALSE;
+  mSmmMpSyncData->AllApArrivedWithException = FALSE;
 }
 
 /**
-- 
2.26.2.windows.1

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

[Chang, Abner]

[AMD Official Use Only - General]

Not the maintainer or reviewer, however

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li,
> Zhihao via groups.io
> Sent: Tuesday, September 27, 2022 8:58 PM
> To: devel@edk2.groups.io
> Cc: Eric Dong <eric.dong@intel.com>; Ray Ni <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when
> BSP Exit in CPU relaxed mode.
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> From: Zhihao Li <zhihao.li@intel.com>
> 
> REF:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D4083&amp;data=05%7C01%7Ca
> bner.chang%40amd.com%7C68a8b6e1f7c240e8be0908daa087df31%7C3dd89
> 61fe4884e608e11a82d994e183d%7C0%7C0%7C637998802683954557%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=Ico5gi7y0nROq
> O5iMmoQxVdm3%2FkK0EHE6Rmu3Rb3PcQ%3D&amp;reserved=0
> 
> In CPU relaxed mode, it doesn't reset the value of
> mSmmMpSyncData->AllApArrivedWithException when BSP exit smm mode.
> So this patch will reset this variable.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> 
> Signed-off-by: Zhihao Li <zhihao.li@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 13c2cb8da4c3..c79da418e37c 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -696,8 +696,9 @@ BSPHandler (
>    //
> 
>    // Allow APs to check in from this point on
> 
>    //
> 
> -  *mSmmMpSyncData->Counter       = 0;
> 
> -  *mSmmMpSyncData->AllCpusInSync = FALSE;
> 
> +  *mSmmMpSyncData->Counter                  = 0;
> 
> +  *mSmmMpSyncData->AllCpusInSync            = FALSE;
> 
> +  mSmmMpSyncData->AllApArrivedWithException = FALSE;
> 
>  }
> 
> 
> 
>  /**
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#94430):
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F94430&amp;data=05%7C01%7Cab
> ner.chang%40amd.com%7C68a8b6e1f7c240e8be0908daa087df31%7C3dd896
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C637998802683954557%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=KJrnDv4XdhieN
> 77nzzfZ%2FQzRkIjqVNrcve0cZaMa5wM%3D&amp;reserved=0
> Mute This Topic:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgrou
> ps.io%2Fmt%2F93948933%2F7039027&amp;data=05%7C01%7Cabner.chang%
> 40amd.com%7C68a8b6e1f7c240e8be0908daa087df31%7C3dd8961fe4884e608
> e11a82d994e183d%7C0%7C0%7C637998802684110789%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=YdMz3rL3MOuU9uBAf0PXjXx
> VrQgYaG2zfYq3zKjt2uU%3D&amp;reserved=0
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Funsub&amp;data=05%7C01%7Cabner.chang%
> 40amd.com%7C68a8b6e1f7c240e8be0908daa087df31%7C3dd8961fe4884e608
> e11a82d994e183d%7C0%7C0%7C637998802684110789%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=rF730ZFxoLMBj7WZ6s%2BKOi
> 9XJky0927Q7CkOKw5nd2U%3D&amp;reserved=0 [abner.chang@amd.com] -
> =-=-=-=-=-=
> 

Re: [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

[Ni, Ray]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Li, Zhihao <zhihao.li@intel.com>
> Sent: Tuesday, September 27, 2022 8:58 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in
> CPU relaxed mode.
> 
> From: Zhihao Li <zhihao.li@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4083
> 
> In CPU relaxed mode, it doesn't reset the value of
> mSmmMpSyncData->AllApArrivedWithException when BSP exit smm mode.
> So this patch will reset this variable.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> 
> Signed-off-by: Zhihao Li <zhihao.li@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 13c2cb8da4c3..c79da418e37c 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -696,8 +696,9 @@ BSPHandler (
>    //
> 
>    // Allow APs to check in from this point on
> 
>    //
> 
> -  *mSmmMpSyncData->Counter       = 0;
> 
> -  *mSmmMpSyncData->AllCpusInSync = FALSE;
> 
> +  *mSmmMpSyncData->Counter                  = 0;
> 
> +  *mSmmMpSyncData->AllCpusInSync            = FALSE;
> 
> +  mSmmMpSyncData->AllApArrivedWithException = FALSE;
> 
>  }
> 
> 
> 
>  /**
> 
> --
> 2.26.2.windows.1

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

[Wu, Jiaxin]

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Saturday, October 8, 2022 2:34 PM
> To: Li, Zhihao <zhihao.li@intel.com>; devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter
> when BSP Exit in CPU relaxed mode.
> 
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> > -----Original Message-----
> > From: Li, Zhihao <zhihao.li@intel.com>
> > Sent: Tuesday, September 27, 2022 8:58 PM
> > To: devel@edk2.groups.io
> > Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in
> > CPU relaxed mode.
> >
> > From: Zhihao Li <zhihao.li@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4083
> >
> > In CPU relaxed mode, it doesn't reset the value of
> > mSmmMpSyncData->AllApArrivedWithException when BSP exit smm
> mode.
> > So this patch will reset this variable.
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> >
> > Signed-off-by: Zhihao Li <zhihao.li@intel.com>
> > ---
> >  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > index 13c2cb8da4c3..c79da418e37c 100644
> > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> > @@ -696,8 +696,9 @@ BSPHandler (
> >    //
> >
> >    // Allow APs to check in from this point on
> >
> >    //
> >
> > -  *mSmmMpSyncData->Counter       = 0;
> >
> > -  *mSmmMpSyncData->AllCpusInSync = FALSE;
> >
> > +  *mSmmMpSyncData->Counter                  = 0;
> >
> > +  *mSmmMpSyncData->AllCpusInSync            = FALSE;
> >
> > +  mSmmMpSyncData->AllApArrivedWithException = FALSE;
> >
> >  }
> >
> >
> >
> >  /**
> >
> > --
> > 2.26.2.windows.1
> 
> 
> 
> 
>