From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from resqmta-c1p-023464.sys.comcast.net (resqmta-c1p-023464.sys.comcast.net [96.102.19.43]) by mx.groups.io with SMTP id smtpd.web12.17372.1664494167563681086 for ; Thu, 29 Sep 2022 16:29:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@comcastmailservice.net header.s=20211018a header.b=q4FsE1BC; spf=softfail (domain: google.com, ip: 96.102.19.43, mailfrom: robwoo@google.com) Received: from resomta-c1p-023268.sys.comcast.net ([96.102.18.235]) by resqmta-c1p-023464.sys.comcast.net with ESMTP id dyrvonJVCBaiTe2y6oJiwb; Thu, 29 Sep 2022 23:29:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1664494166; bh=z9gbrihOAvt6IcSJOA4b7A/RsJEh2ohlyr1+1LIVmx0=; h=Received:Received:From:To:Subject:Date:Message-Id:MIME-Version: Content-Type; b=q4FsE1BChccm0o/6DwmLDLNFb4ZymsR8InVZDDM5h9SJDa8cmW9ni88eh12SHiz90 fw92jSoGwVEPGDak/0UdoDczz9X/lwKPmRhZcHy1ExcnP3EMIBEKh2tM008Cyih37n 9v8yhrxOCtstX4N/zgsjmBQGR8Zg93ZKGd+NtZ1fhFa27fx4FNFnlZJtNUo8avGUGe 5HZmGPIGYaNRRvjQTTF3P8vu968mEJLL7xfw1kDlncryXRl1kB1BaaYqVgdPIvZ84W 8HVizRmieCaS9U6a9NysV7dcdVvevRnvU9pXW1j4tX8kwE2Fi4GgfUKE4ZK3P4fgAS d/PuPSSdyqCGg== Received: from robwoo-glaptop.corp.google.com ([IPv6:2620:15c:10f:203:594f:9ced:6f7b:f5e2]) by resomta-c1p-023268.sys.comcast.net with ESMTPA id e2xOoquhPe6l6e2xyoHvS8; Thu, 29 Sep 2022 23:29:24 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit From: "Robert Wood" To: devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud Subject: [PATCH v1 1/1] MiscBootServices: Stall_Func: Reduces the stall interval for Stall_Func Date: Thu, 29 Sep 2022 16:28:41 -0700 Message-Id: <20220929232841.87723-2-robwoo@google.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20220929232841.87723-1-robwoo@google.com> References: <20220929232841.87723-1-robwoo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The Stall_Func test on the highest TPL causes issues with the disk IO by blocking interrupts. This blocking can cause disk corruption through IO timeouts. Since this doesn't seem to be the intent of the test this revision reduces the stall interval from 10 seconds to 4 and adjusts the delta=C2=A0tolerance in scale. Signed-off-by: Robert Wood Cc: Samer El-Haj-Mahmoud --- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestMain.h | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTe= st/MiscBootServicesBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestMain.h b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestMain.h index 9e98ec013c74..4f8eaa4c70ea 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestMain.h @@ -46,7 +46,7 @@ typedef struct _RESET_DATA { { 0xA6033499, 0xE4AF, 0x44f5, {0x9D, 0x16, 0x30, 0x78, 0xD8, 0x61, 0x32, = 0x28 }}=0D =0D #define TPL_ARRAY_SIZE 3=0D -#define MAX_SECOND_MARGIN 2=0D +#define MAX_SECOND_MARGIN 1=0D =0D //=0D // Change size from TPL_ARRAY_SIZE to TPL_ARRAY_SIZE + 1=0D diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootService= s/BlackBoxTest/MiscBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/= UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestF= unction.c index ad72646bada2..f831ed6fbccc 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/Black= BoxTest/MiscBootServicesBBTestFunction.c @@ -827,7 +827,7 @@ BBTestStallInterfaceTest ( StartTime =3D Epoch; OldTpl =3D gtBS->RaiseTPL (TplArray[Index]);=0D Status =3D gtBS->Stall (=0D - 10000000=0D + 4000000=0D );=0D gtBS->RestoreTPL (OldTpl);=0D if (gtRT->GetTime (&EndTime, NULL) !=3D EFI_SUCCESS) --=20 2.38.0.rc1.362.ged0d419d3c-goog