public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Rebecca Cran <rebecca@bsdio.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>
Subject: [PATCH v6 16/19] SecurityPkg/RngDxe: Add debug warning for NULL PcdCpuRngSupportedAlgorithm
Date: Fri, 30 Sep 2022 18:05:29 +0200	[thread overview]
Message-ID: <20220930160532.2921381-17-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20220930160532.2921381-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <pierre.gondois@arm.com>

PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm
used by the RNDR CPU instruction to generate a random number.
Add a debug warning if the Pcd is not set.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 .../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c      | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
index f5910e3b999f..0d853720ecb1 100644
--- a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
+++ b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
@@ -67,6 +67,16 @@ GetAvailableAlgorithms (
       sizeof (EFI_RNG_ALGORITHM)
       );
     mAvailableAlgoArrayCount++;
+
+    DEBUG_CODE_BEGIN ();
+    if (IsZeroGuid (PcdGetPtr (PcdCpuRngSupportedAlgorithm))) {
+      DEBUG ((
+        DEBUG_WARN,
+        "PcdCpuRngSupportedAlgorithm should be a non-zero GUID\n"
+        ));
+    }
+
+    DEBUG_CODE_END ();
   }
 
   // Raw algorithm (Trng)
-- 
2.25.1


  parent reply	other threads:[~2022-09-30 16:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30 16:05 [PATCH v6 00/19] Add Raw algorithm support using Arm FW-TRNG interface PierreGondois
2022-09-30 16:05 ` [PATCH v6 01/19] ArmPkg: PCD to select conduit for monitor calls PierreGondois
2022-09-30 16:05 ` [PATCH v6 02/19] ArmPkg/ArmMonitorLib: Definition for ArmMonitorLib library class PierreGondois
2022-09-30 16:05 ` [PATCH v6 03/19] ArmPkg/ArmMonitorLib: Add ArmMonitorLib PierreGondois
2022-09-30 16:05 ` [PATCH v6 04/19] ArmPkg: Sort HVC/SMC section alphbetically in ArmPkg.dsc PierreGondois
2022-09-30 16:05 ` [PATCH v6 05/19] ArmPkg/ArmHvcLibNull: Add NULL instance of ArmHvcLib PierreGondois
2022-09-30 16:05 ` [PATCH v6 06/19] MdePkg/TrngLib: Definition for TRNG library class interface PierreGondois
2022-09-30 16:05 ` [PATCH v6 07/19] MdePkg/TrngLib: Add NULL instance of TRNG Library PierreGondois
2022-09-30 16:05 ` [PATCH v6 08/19] ArmPkg: Add FID definitions for Firmware TRNG PierreGondois
2022-09-30 16:05 ` [PATCH v6 09/19] ArmPkg/TrngLib: Add Arm Firmware TRNG library PierreGondois
2022-09-30 16:05 ` [PATCH v6 10/19] SecurityPkg/RngDxe: Rename RdRandGenerateEntropy to generic name PierreGondois
2022-09-30 16:05 ` [PATCH v6 11/19] SecurityPkg/RngDxe: Replace Pcd with Sp80090Ctr256Guid PierreGondois
2022-09-30 16:05 ` [PATCH v6 12/19] SecurityPkg/RngDxe: Remove ArchGetSupportedRngAlgorithms() PierreGondois
2022-09-30 16:05 ` [PATCH v6 13/19] SecurityPkg/RngDxe: Documentation/include/parameter cleanup PierreGondois
2022-09-30 16:05 ` [PATCH v6 14/19] SecurityPkg/RngDxe: Check before advertising Cpu Rng algo PierreGondois
2022-09-30 16:05 ` [PATCH v6 15/19] SecurityPkg/RngDxe: Add AArch64 RawAlgorithm support through TrngLib PierreGondois
2022-09-30 16:05 ` PierreGondois [this message]
2022-09-30 16:05 ` [PATCH v6 17/19] SecurityPkg/RngDxe: Rename AArch64/RngDxe.c PierreGondois
2022-09-30 16:05 ` [PATCH v6 18/19] SecurityPkg/RngDxe: Add Arm support of RngDxe PierreGondois
2022-09-30 16:05 ` [PATCH v6 19/19] ArmVirtPkg: Kvmtool: Add RNG support using FW-TRNG interface PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220930160532.2921381-17-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox