[PATCH 0/2] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib.

[PATCH 0/2] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib.

[Chiu, Chasel]

To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

Chasel Chiu (2):
  IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib.
  IntelFsp2WrapperPkg: Remove CI exception of PlatformMultiPhaseLib.

 IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c |  2 +-
 IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h                           | 18 ------------------
 IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h                          | 30 ++++++++++++++++++++++++++++++
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml                                                |  6 +-----
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec                                                    |  2 +-
 5 files changed, 33 insertions(+), 25 deletions(-)
 create mode 100644 IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h

-- 
2.35.0.windows.1

[PATCH 1/2] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib.

[Chiu, Chasel]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092

To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c |  2 +-
 IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h                           | 18 ------------------
 IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h                          | 30 ++++++++++++++++++++++++++++++
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec                                                    |  2 +-
 4 files changed, 32 insertions(+), 20 deletions(-)

diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c
index 3ddc07690a..1248accf87 100644
--- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c
+++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c
@@ -16,7 +16,7 @@
 #include <Ppi/ReadOnlyVariable2.h>
 #include <Ppi/Variable.h>
 #include <Library/PeiServicesLib.h>
-#include <Library/FspWrapperMultiPhaseProcessLib.h>
+#include <Library/FspWrapperPlatformMultiPhaseLib.h>
 
 /**
   Execute 32-bit FSP API entry code.
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
index 65a5db233f..aadacc9b50 100644
--- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h
@@ -9,24 +9,6 @@
 #ifndef __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__
 #define __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__
 
-/**
-  FSP Wrapper Platform MultiPhase Handler
-
-  @param[in] FspHobListPtr        - Pointer to FSP HobList (valid after FSP-M completed)
-  @param[in] ComponentIndex       - FSP Component which executing MultiPhase initialization.
-  @param[in] PhaseIndex           - Indicates current execution phase of FSP MultiPhase initialization.
-
-  @retval EFI_STATUS        Always return EFI_SUCCESS
-
-**/
-VOID
-EFIAPI
-FspWrapperPlatformMultiPhaseHandler (
-  IN OUT VOID  **FspHobListPtr,
-  IN UINT8     ComponentIndex,
-  IN UINT32    PhaseIndex
-  );
-
 /**
   FSP Wrapper Variable Request Handler
 
diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h
new file mode 100644
index 0000000000..272b0e3911
--- /dev/null
+++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h
@@ -0,0 +1,30 @@
+/** @file
+  Provide FSP wrapper Platform MultiPhase handling functions.
+
+  Copyright (c) 2022, Intel Corporation. All rights reserved.<BR>
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef FSP_WRAPPER_PLATFORM_MULTI_PHASE_LIB_H_
+#define FSP_WRAPPER_PLATFORM_MULTI_PHASE_LIB_H_
+
+/**
+  FSP Wrapper Platform MultiPhase Handler
+
+  @param[in] FspHobListPtr        - Pointer to FSP HobList (valid after FSP-M completed)
+  @param[in] ComponentIndex       - FSP Component which executing MultiPhase initialization.
+  @param[in] PhaseIndex           - Indicates current execution phase of FSP MultiPhase initialization.
+
+  @retval EFI_STATUS        Always return EFI_SUCCESS
+
+**/
+VOID
+EFIAPI
+FspWrapperPlatformMultiPhaseHandler (
+  IN OUT VOID  **FspHobListPtr,
+  IN UINT8     ComponentIndex,
+  IN UINT32    PhaseIndex
+  );
+
+#endif //FSP_WRAPPER_PLATFORM_MULTI_PHASE_LIB_H_
diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
index 95ada0f7a1..922ccc063f 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
@@ -33,7 +33,7 @@
   FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProcessLib.h
 
   ##  @libraryclass  Provide MultiPhase platform actions related functions.
-  FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProcessLib.h
+  FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperPlatformMultiPhaseLib.h
 
 
 [Guids]
-- 
2.35.0.windows.1

[PATCH 2/2] IntelFsp2WrapperPkg: Remove CI exception of PlatformMultiPhaseLib.

[Chiu, Chasel]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092

Duplicate library class header issue will be resolved and CI
exception for FspWrapperPlatformMultiPhaseLib should be removed too.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
index 6788a723a1..45cb5a7d6f 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
@@ -78,11 +78,7 @@
 
     ## options defined .pytool/Plugin/LibraryClassCheck
     "LibraryClassCheck": {
-        "IgnoreLibraryClass": [
-          # This header file contains a small function in a separate library so platforms
-          # do not have to override the whole main library instance.
-          "FspWrapperPlatformMultiPhaseLib"
-        ]
+        "IgnoreLibraryClass": []
     },
 
     ## options defined .pytool/Plugin/SpellCheck
-- 
2.35.0.windows.1

Re: [edk2-devel] [PATCH 2/2] IntelFsp2WrapperPkg: Remove CI exception of PlatformMultiPhaseLib.

[Michael Kubacki]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 10/4/2022 9:22 PM, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
> 
> Duplicate library class header issue will be resolved and CI
> exception for FspWrapperPlatformMultiPhaseLib should be removed too.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>   IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> index 6788a723a1..45cb5a7d6f 100644
> --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.ci.yaml
> @@ -78,11 +78,7 @@
>   
> 
>       ## options defined .pytool/Plugin/LibraryClassCheck
> 
>       "LibraryClassCheck": {
> 
> -        "IgnoreLibraryClass": [
> 
> -          # This header file contains a small function in a separate library so platforms
> 
> -          # do not have to override the whole main library instance.
> 
> -          "FspWrapperPlatformMultiPhaseLib"
> 
> -        ]
> 
> +        "IgnoreLibraryClass": []
> 
>       },
> 
>   
> 
>       ## options defined .pytool/Plugin/SpellCheck
>